Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a notification email when performance drops between runs #13

Open
ryanjulian opened this issue Jul 2, 2019 · 3 comments
Open

Generate a notification email when performance drops between runs #13

ryanjulian opened this issue Jul 2, 2019 · 3 comments

Comments

@ryanjulian
Copy link
Member

No description provided.

@sud0nick
Copy link

@cheng-kevin and @ryanjulian How should the performance drop be measured? Should it be based on a lower threshold, a minimum allowed value relative to the previous run, or something else?

@krzentner
Copy link

krzentner commented Aug 1, 2019 •
edited
Loading

I feel like having a fixed threshold per-benchmark will be easier to implement and debug, so let's go with that.

@sud0nick
Copy link

sud0nick commented Aug 3, 2019

@krzentner sounds good. What threshold value is acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryanjulian @sud0nick @krzentner