-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking for support to kernel 6.0+ #67
Comments
Would also love this. Experiencing the same thing on:
|
Hi, i've noticed the same problem since updating to Linux Kernel 6. I don't have much in-depth knowledge of Linux, so my "quick, dirty workaround" is the following: As some of the efivar API doesn't seem to be available anymore (don't know if it's been deprecated or was internal), the compilation fails with the 'applespi_get_saved_bl_level' and the 'applespi_save_bl_level' function. Since it is not a big deal-breaker for me if the backlight levels don't get saved in between boots, I just changed them into dummy functions for now ;) |
Great to hear you got it working. I tried your method and loaded the modules using dkms. Doesn't load on boot because it's asking for it to be signed?
|
Weird, I have the same kernel version installed and I'm also on Arch. I just did: make all && make install, this worked for me. |
Looks like it did work! I just had to disable |
Great to hear that you got it to work and yes I think it's a known problem that the device rules of usbmuxd interfere with the touchbar driver. (see #42) |
You can try https://github.com/almas/macbook12-spi-driver/tree/touchbar-driver-hid-driver |
It worked perfectly for me, thanks a lot |
Hi, im on Ubuntu with 6.8.0-40-generic Kernel and i have same issue, it has error like this : dkms install -m applespi -v 0.1
Creating symlink /var/lib/dkms/applespi/0.1/source -> /usr/src/applespi-0.1
Kernel preparation unnecessary for this kernel. Skipping...
Building module:
cleaning build area...
make -j16 KERNELRELEASE=6.8.0-40-generic...(bad exit status: 2)
ERROR (dkms apport): binary package for applespi: 0.1 not found
Error! Bad return status for module build on kernel: 6.8.0-40-generic (x86_64)
Consult /var/lib/dkms/applespi/0.1/build/make.log for more information.
|
I have the same error.
This is didn't work for me for |
Hi, Hope this finds you well. It appears that the code you've sent doesn't work on 6.11.3-gentoo with the t2linux patches. build log: https://pastebin.com/QiYm4LYK |
I don't know if it's the module that doesn't work, or tiny-dfr... But I have got the module compiling with this patch: diff --git a/apple-ib-als.c b/apple-ib-als.c
index 9cb4347..5c4f26b 100644
--- a/apple-ib-als.c
+++ b/apple-ib-als.c
@@ -645,7 +645,7 @@ error:
return rc;
}
-static int appleals_platform_remove(struct platform_device *pdev)
+static void appleals_platform_remove(struct platform_device *pdev)
{
struct appleib_device_data *ddata = pdev->dev.platform_data;
struct appleib_device *ib_dev = ddata->ib_dev;
@@ -658,10 +658,10 @@ static int appleals_platform_remove(struct platform_device *pdev)
kfree(als_dev);
- return 0;
+ return;
error:
- return rc;
+ return;
}
static const struct platform_device_id appleals_platform_ids[] = {
diff --git a/apple-ib-tb.c b/apple-ib-tb.c
index 2b1763e..57b0b90 100644
--- a/apple-ib-tb.c
+++ b/apple-ib-tb.c
@@ -1259,7 +1259,7 @@ error:
return rc;
}
-static int appletb_platform_remove(struct platform_device *pdev)
+static void appletb_platform_remove(struct platform_device *pdev)
{
struct appleib_device_data *ddata = pdev->dev.platform_data;
struct appleib_device *ib_dev = ddata->ib_dev;
@@ -1272,10 +1272,11 @@ static int appletb_platform_remove(struct platform_device *pdev)
appletb_free_device(tb_dev);
- return 0;
+ return;
error:
- return rc;
+// return rc;
+ return;
}
static const struct platform_device_id appletb_platform_ids[] = {
diff --git a/apple-ibridge.c b/apple-ibridge.c
index b176e32..858fd33 100644
--- a/apple-ibridge.c
+++ b/apple-ibridge.c
@@ -898,7 +898,7 @@ MODULE_DEVICE_TABLE(acpi, appleib_acpi_match);
static struct acpi_driver appleib_driver = {
.name = "apple-ibridge",
.class = "topcase", /* ? */
- .owner = THIS_MODULE,
+ //.owner = THIS_MODULE,
.ids = appleib_acpi_match,
.ops = {
.add = appleib_probe, |
For anyone interested, I forked the module and added the patch. This one compiles just fine on 6.11.x afaik. |
Trying to compile on Debian testing I get the following trace:
Here some details about local setup on Debian testing (bookworm):
The text was updated successfully, but these errors were encountered: