From 19fca521dbdfdf5912ecc339af1a3037133bd151 Mon Sep 17 00:00:00 2001
From: Mikhail Denisenko <denisenkom@gmail.com>
Date: Wed, 11 Sep 2019 23:11:09 -0400
Subject: [PATCH] more test coverage for decimal

---
 internal/decimal/decimal_test.go | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/internal/decimal/decimal_test.go b/internal/decimal/decimal_test.go
index 6b93ec8f..4086a964 100644
--- a/internal/decimal/decimal_test.go
+++ b/internal/decimal/decimal_test.go
@@ -116,6 +116,7 @@ func TestFromInt64(t *testing.T) {
 		{12345, 3, "12.345"},
 		{math.MaxInt64, 0, "9223372036854775807"},
 		{math.MinInt64, 0, "-9223372036854775808"},
+		{-100, 0, "-100"},
 	}
 	for _, v := range values {
 		dec := Int64ToDecimalScale(v.in, v.scale)
@@ -156,3 +157,27 @@ func TestFromString(t *testing.T) {
 		}
 	}
 }
+
+func TestFromStringBad(t *testing.T) {
+	arr := make([]rune, 256)
+	for i := range arr {
+		arr[i] = '0'
+	}
+	bigScaleNumber := "0." + string(arr) + "1"
+
+	values := []struct {
+		in string
+		scale uint8
+	}{
+		{"0.0001", 2},
+		{bigScaleNumber, 2},
+		{"not a number", 2},
+		{"400000000000000000000000000000000000000", 2},
+	}
+	for _, v := range values {
+		_, err := StringToDecimalScale(v.in, v.scale)
+		if err == nil {
+			t.Error("expected to fail but it didn't")
+		}
+	}
+}