GIF image type support in PDF mode?

[hantsaniala]

Is your feature request related to a problem? Please describe.
Sometimes, some chapters are in GIF format and are skipped when downloading. So some books end up without a single content inside.

Describe the solution you'd like
Support GIF format for PDF export.

Describe alternatives you've considered
CBZ format doesn't have this problem, but the page content is not right.

Additional context
OS: Ubuntu 24.04.1
Go: Go 1.22.2

Example URL: https://www.webtoons.com/en/slice-of-life/murrz/ep-226-devil-flowers/viewer?title_no=1281&episode_no=226

CBZ glitch

[robinovitch61]

Thanks for this feature request @hantsaniala! Would you want to have a go at adding the feature yourself and making a pull request to get it in the next release? I'm a bit tied up with work and other projects.

If you want a hand getting set up for making a code change in this repo, I can add a CONTRIBUTING file with further guidance, LMK!

[hantsaniala]

I was about to make a PR for the PDF but stuck with some logic that I'm little bit lost. import _ "image/gif" fix the unknown type error but I still have blank page problem using c.pdf.ImageByHolder(). Any hint to how to fix this? I'll PR if I found a solution.

[robinovitch61]

If you open a draft PR with your attempt so far, I can take a look at it when I get some time!

[hantsaniala]

Here please. I'm still looking for solution but if you can hint me where to go, I can fix it.

[ArchieBVox]

The pdf library gopdf doesn't currently support gif only jpg & png, I have a pull request for gopdf to add gif support that is the result of prototyping gif support for this repo.

If you want to add gif support before gopdf adds gif support, you'll want to add logic to convert gifs to pngs using image.Decode(...) & png.Encode(...).

[ArchieBVox]

gopdf v0.29.0 includes gif support, if you update to (that) version or later the changes in the WIP: Feature/pdf gif support should work. I have it working in my own gif-support branch that includes similar changes