-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serving multiple libraries by one server #19
Comments
Hi there, Do you have an estimated time of delivery for this change? Regards, Jw |
Unfortunately I doubt I have time look at this in the near future. Getting RF 2.8.5 out and then starting RF 2.9 is likely more important for my main client. Sponsoring the development or providing a pull request would obviously fasten the development. Let me know if you are interested in either of them and we can agree on details. |
Hi. My robotframework-tools contain an extended https://github.com/userzimmermann/robotframework-tools#4-using-robot-framework-remotely |
So with Robot Remote server we can host multiple libraries ? |
@userzimmermann: Cool! Interested to provide a pr here too? |
@samratashok87 Hi. Thanks for your interest. And sorry for the late answer :) @pekkaklarck Nice that you are also interested in that stuff :) Regarding a PR: Honestly, I don't want to put effort into extracting my derived |
I have made some changes in the project to accept multiple libraries on a new branch. I don't have permission on the project to push. This is my own repository: |
Great that you are interested to help with this. I looked at your repo, but for some reason it seems that you have modified all files and it's totally impossible to see the actual changes. Probably best if you fork the repository again and add you changes on top of it. I'd also recommend creating a separate topic branch for the work as it makes it easier to create pull request later. |
Hi Dear Pekka,
I will contribute my changes on the original project as soon as it's
possible. :-)
…On Mon, Sep 18, 2017 at 1:44 PM, Pekka Klärck ***@***.***> wrote:
Great that you are interested to help with this. I looked at your repo,
but for some reason it seems that you have modified all files and it's
totally impossible to see the actual changes. Probably best if you fork the
repository again and add you changes on top of it. I'd also recommend
creating a separate topic branch for the work as it makes it easier to
create pull request later.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATBblbJuHcJir_LGiZuwlZ90XIIcEGdoks5sjjRjgaJpZM4Bqh9J>
.
|
Changes has been made to support serving a list of libraries: robotframework#19
Changes has been made to support serving a list of libraries: robotframework#19
@pekkaklarck It seems that @zeinababbasi patch works. I have tested it with my libraries and it works. |
Great to hear that the code works. I still don't see any pull-request and that makes reviewing and merging changes hard. Are you @zeinababbasi interested to create a PR? If not, are you @livelace? |
Hi, |
It seems I have missed PR #47 that implements this. Unfortunately all my development time is currently spent with Robot Framework core and I don't really have time for this project until RF 3.1 is released. |
Hi, |
Any chance we may be able to get this in still? We are finding a need for it as well and this would eliminate our need to have 10-12 of these running. |
I'm sure this is added at some point, but unfortunately my time is still spent with Robot Framework core and at the moment with trying to get RF 3.2 ready. I'd be ready to share maintainer responsibilities with someone else if there'd be interest. |
Changes has been made to support serving a list of libraries: robotframework#19
Changes has been made to support serving a list of libraries: robotframework#19
One thing that seems to work (YMMV) is creating a new class that inherits all of your libraries classes, effectively wrapping them into a single class. I say YMMV because there's bound to be edge cases folks will run into around name collisions for methods and fields, but at a high level this approach seems to work and provide a quick hack to enable this functionality. from lib_a import LibraryA
from lib_b import LibraryB
from robotremoteserver import RobotRemoteServer
class MergedLibraries(LibraryA, LibraryB):
pass
RobotRemoteServer(MergedLibraries()) |
This would obviously ease hosting multiple libraries considerably. jrobotremoteserver by @ombre42 already handles this.
The text was updated successfully, but these errors were encountered: