Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale issue on anything but Windows #13

Open
Stoner19 opened this issue Apr 15, 2020 · 3 comments
Open

Locale issue on anything but Windows #13

Stoner19 opened this issue Apr 15, 2020 · 3 comments

Comments

@Stoner19
Copy link

Trying to compile and run this on an OSX machine I come across an issue with locale. It appears that English_United States.1252 is only recognized by Windows, while the rest of the world works in en_US.UTF-8

https://github.com/Robswc/tradingview-trainer/blob/master/app/app.py#L37

@betegon
Copy link
Contributor

betegon commented May 9, 2020

@Stoner19 is right.

Change this line to the following in order to make it work in Linux envs:

locale.setlocale(locale.LC_ALL, 'en_US.UTF-8')

Please @robswc check my pull request, #16 , to resolve this issue.

Also, it would be epic if @Stoner19 could test it out in his part.

@robswc
Copy link
Owner

robswc commented May 9, 2020

@betegon thanks a ton for the fixes, awesome!

@betegon
Copy link
Contributor

betegon commented May 9, 2020

No worries @robswc !

You can close this issue now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants