Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Server #42

Open
annaborn opened this issue Feb 25, 2021 · 2 comments
Open

TCP Server #42

annaborn opened this issue Feb 25, 2021 · 2 comments

Comments

@annaborn
Copy link

annaborn commented Feb 25, 2021

Hello Sylvain @doudou,

in this library I found an implementation for TCP server in src/TCPDriver. However, it was not mentioned in Readme and was not integrated in the correspondend orogen. Is there some particalur reason for it?

I am currently using the TCPDriver, and seems to work well. I would like to overwork the TCPDriver to add more functionality and fixes. e.g. a possibility to check from outside if a client is connected or disconnected. Also, it needs to be integrated into iodrivers_base orogen component to be used fully. Some changes I have already implemented.

My question is, would it be of particular interest to have functional TCP Server in this lib and its orogen?
Are there some restirctions that I should take into account?

Thank you!

@doudou
Copy link
Member

doudou commented Feb 25, 2021

I think it would make sense to have a tcp server integrated in iodrivers_base::Driver as a stream, the same way there is a UDP "server", if that's what you have in mind.

A separate TCP server class and component ? I don't see it, no. If only because I'm guessing there is already much better and feature-complete implementations for TCP in C++ out there.

@annaborn
Copy link
Author

@doudou Hello Sylvain,

I added TCP server as stream into the library. Also I am using this implemantion already in our project.

Could you please take a look? #43

At the moment the tcp server can handle only one connection. If a new client will request a conntection to the server, the server will switch to it. I took this concept from TCPDriver.cpp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants