Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File names for 8.7 and 9.1 installation docs #1088

Closed
wsoyinka opened this issue Mar 7, 2023 · 7 comments
Closed

File names for 8.7 and 9.1 installation docs #1088

wsoyinka opened this issue Mar 7, 2023 · 7 comments

Comments

@wsoyinka
Copy link
Member

wsoyinka commented Mar 7, 2023

We should probably update the "file names" of install docs from 8.6 and 9.0 to --> 8.7 and 9.1 version respectively. Ditto all corresponding translated files and .pages.

@sspencerwire thoughts ?

@NezSez
Copy link
Contributor

NezSez commented Apr 17, 2023

Isn't how we do this related to #1044 ? From what I've read so far, which isn't much, the mike plugin requires the use of

<major>.<minor>

directories right?

@sspencerwire
Copy link
Contributor

@wsoyinka the problem is the translations:

8_6_installation.fr.md
8_6_installation.it.md
8_6_installation.ja.md
8_6_installation.md
8_6_installation.sv.md
8_6_installation.zh.md

The 9.x documents suffer none of this, as they are simply named "installation.md" I can rename the source document for 8.x to 8_8_installation.md or simply 8_installation.md, which will hold true until 8 is EOLed. What do you think? The translations will still be an issue and will probably look like they haven't been completed at all.

@sspencerwire
Copy link
Contributor

@wsoyinka the problem is the translations:

8_6_installation.fr.md
8_6_installation.it.md
8_6_installation.ja.md
8_6_installation.md
8_6_installation.sv.md
8_6_installation.zh.md

The 9.x documents suffer none of this, as they are simply named "installation.md" I can rename the source document for 8.x to 8_8_installation.md or simply 8_installation.md, which will hold true until 8 is EOLed. What do you think? The translations will still be an issue and will probably look like they haven't been completed at all.

@wsoyinka I responded to this back in June... Do you want to go ahead with this, or should we close the issue?

@sspencerwire
Copy link
Contributor

@all-contributors add @ShyRain for content

Copy link
Contributor

@sspencerwire

I've put up a pull request to add @ShyRain! 🎉

@sspencerwire
Copy link
Contributor

@wsoyinka I think we should close this issue, unless you want it?? Let me know.

@wsoyinka
Copy link
Member Author

Fine with this @sspencerwire . Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants