Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default PID values #34

Closed
rodeo-sam opened this issue Feb 4, 2015 · 4 comments
Closed

Default PID values #34

rodeo-sam opened this issue Feb 4, 2015 · 4 comments

Comments

@rodeo-sam
Copy link
Owner

PID values should be defined as a global variable to go easy on the EEPROM. Also there should be default values which should be used in case there are no values written to the EEPROM or the EEPROM breaks.

Custom values can be written to EEPROM (see #33) and will be used then.

@oni303
Copy link
Collaborator

oni303 commented Feb 4, 2015

lets not use variables for static values like, lets take defines

@rodeo-sam
Copy link
Owner Author

But you might not want to read the EEPROM everytime you run the calculation.

@yschroeder
Copy link
Collaborator

  1. define default values in config.h
  2. initialize P, I ,D variables with these values
  3. check if other values are present in the eeprom
  4. update the P, I, D variables if eeprom has data
  5. ...
  6. profit

@yschroeder yschroeder added this to the running version milestone Feb 9, 2015
@oni303
Copy link
Collaborator

oni303 commented Feb 12, 2015

DONE

@oni303 oni303 closed this as completed Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants