Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaperWallet.CreateOrderOCO doesn't support buy side #256

Open
ramilexe opened this issue Apr 3, 2023 · 4 comments
Open

PaperWallet.CreateOrderOCO doesn't support buy side #256

ramilexe opened this issue Apr 3, 2023 · 4 comments
Labels
kind/feature

Comments

@ramilexe
Copy link
Contributor

ramilexe commented Apr 3, 2023

It seems CreateOrderOCO supports only sell option https://github.com/rodrigo-brito/ninjabot/blob/main/exchange/paperwallet.go#L409-L412
@ramilexe
Copy link
Contributor Author

ramilexe commented Apr 3, 2023

Because of that, backtesting doesn't work properly:
image
I have short position and create OCO order for TP/SL. And both these orders get filled.

@rodrigo-brito
Copy link
Owner

The bot do not support OCO orders for futures market yet.
Futures Market are in an experimental phase.

@ramilexe
Copy link
Contributor Author

ramilexe commented Apr 5, 2023

@rodrigo-brito I am using PaperWallet with backtesting, not Binance Future

@rodrigo-brito
Copy link
Owner

Of course, we can try to work on that support, but we don't have that implemented right now. If you want to work on this feature, help is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ramilexe @rodrigo-brito