Clarification on Computed and dispose()

[Solido]

Here's a test with a listSignal as source.
It will create a select that allows only blue
If two blue pass the filter then add a green to original signal and dispose select

I cannot figure out the output as it add a second green after it dipose and specific logs.

Thanks a lot for any advice on how to model that.

I can move s.add('green'); to onDispose to avoid the doublon but trying to understand the second call.
Probably expecting than calling dispose() will unsub further events.

test('Resources Resolver', () {
      final s = listSignal(['red', 'blue'], debugLabel: 'source');

      final c1 = s.select(
          (resources) => resources().where((r) {
                if (r != 'blue') return false;
                return true;
              }),
          debugLabel: 'select');

      c1
        ..onDispose(() {
          print('==>disposed');
        })
        ..subscribe((cps) {
          print('cps: $cps');
          if (cps.length == 2) {
            print('grant a green');
            s.add('green');
            c1.dispose();
          }
        });

      s.add('red');
      print('after red: $s / $c1');
      s.add('blue');
      print('after blue: $s / $c1');

      print('$s / $c1');
    });

`
cps: (blue)
cps: (blue)
after red: [red, blue, red] / (blue)
cps: (blue, blue)
grant a green
==>disposed
computed warning: [421|select] has been read after disposed: #0 Computed.value (package:signals_core/src/core/computed.dart:522:97)
#1 ReadonlySignal.subscribe. (package:signals_core/src/core/readonly.dart:95:26)
#2 Effect._callback (package:signals_core/src/core/effect.dart:258:32)
#3 _endBatch (package:signals_core/src/core/batch.dart:29:18)
#4 Signal.set (package:signals_core/src/core/signal.dart:513:7)
#5 ListSignal.add (package:signals_core/src/value/list.dart:77:5)
#6 main.. (file:///Users/robbie/Documents/Dev/flutter_playboard/board_logic/test/resource_test.dart:128:9)
#7 Declarer.test.. (package:test_api/src/backend/declarer.dart:215:19)

#8 Declarer.test. (package:test_api/src/backend/declarer.dart:213:7)

#9 Invoker._waitForOutstandingCallbacks. (package:test_api/src/backend/invoker.dart:258:9)

cps: (blue, blue)
grant a green
computed warning: [421|select] has been read after disposed: #0 Computed.value (package:signals_core/src/core/computed.dart:522:97)
#1 ReadonlySignal.toString (package:signals_core/src/core/readonly.dart:51:26)
#2 _StringBase._interpolate (dart:core-patch/string_patch.dart:871:19)
#3 main.. (file:///Users/robbie/Documents/Dev/flutter_playboard/board_logic/test/resource_test.dart:129:35)
#4 Declarer.test.. (package:test_api/src/backend/declarer.dart:215:19)

#5 Declarer.test. (package:test_api/src/backend/declarer.dart:213:7)

#6 Invoker._waitForOutstandingCallbacks. (package:test_api/src/backend/invoker.dart:258:9)

after blue: [red, blue, red, blue, green, green] / (blue, blue)
computed warning: [421|select] has been read after disposed: #0 Computed.value (package:signals_core/src/core/computed.dart:522:97)
#1 ReadonlySignal.toString (package:signals_core/src/core/readonly.dart:51:26)
#2 _StringBase._interpolate (dart:core-patch/string_patch.dart:871:19)
#3 main.. (file:///Users/robbie/Documents/Dev/flutter_playboard/board_logic/test/resource_test.dart:131:23)
#4 Declarer.test.. (package:test_api/src/backend/declarer.dart:215:19)

#5 Declarer.test. (package:test_api/src/backend/declarer.dart:213:7)

#6 Invoker._waitForOutstandingCallbacks. (package:test_api/src/backend/invoker.dart:258:9)

[red, blue, red, blue, green, green] / (blue, blue)
`

[rodydavis]

Try doing .toList() after the where() because it currently is a lazy iterable

[Solido]

Didn't make it. Seems like c1.dispose(); does not break the listening even if called before s.add('green');

I was expecting for select to create an isolated signal from source and then be able to shut it down without impacting or reacting to original source.

I may have to end up extending Computed and managed a boolean to manage the dispose() call state but that would be overkill.