Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psuedocode feedback #2

Open
bayknight opened this issue Oct 16, 2023 · 0 comments
Open

Psuedocode feedback #2

bayknight opened this issue Oct 16, 2023 · 0 comments

Comments

@bayknight
Copy link

Good start, Ross. I think you have a decent framework but may be missing some key points.

If you use and UMI as a key youll only be able to store N=UMI count number of files. are you going to clear this out between chromosomes?

@ lines need to be stored in the output file.

Reverse reads need to be adjusted based on the CIGAR string as well.
Softclipping is not hte only thing needed to account for in CIGAR string for reverse reads.

"proper strand" is not determined by if its a forward or reverse read I believe.

I may have missed it but i didnt see any psuedo functions.

overall i still think this is a good framework and once you start implementing this the issues will get flushed out. I think some stuff regarding start position is confusing and will be clarified in class I think. The psuedocode was easy to read and i appreciate the example walkthrough you put in textblocks at the top. I think the Problem could have been expanded a bit, but was still pretty good. Good job, Ross!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant