Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement gohack diff subcommand #32

Open
rogpeppe opened this issue Oct 17, 2018 · 1 comment
Open

implement gohack diff subcommand #32

rogpeppe opened this issue Oct 17, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@rogpeppe
Copy link
Owner

When we do gohack get of a module without specifying the -vcs flag, we record the checksum so we can later report that the source has been changed, but we have know way of informing the user exactly what has been changed.

We should record the version that's being checked out as well as the checksum. That way we can find out what's changed (using gohack diff). This also potentially allows us to switch from default to VCS mode while preserving changes made by the user.

One potentially issue with implementing this command is that it's potentially a slippery slope towards adding endless diff features.

@rogpeppe rogpeppe added the enhancement New feature or request label Oct 17, 2018
@josharian
Copy link
Contributor

If you use github.com/pkg/diff to provide the diff, then there'll be much less temptation to support adding endless diff features, since package diff probably doesn't support them. :) And it doesn't require an external diff tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants