Sunrise/Sunset IR led feature

[Meinadigitalworld]

Hi,

Would it be nice to have under the Camera Settings, an enable/disable switch that would turn ON/OFF the IR led based on the Sunrise/Sunset for the chosen Timezone? The IR Led toggle switch would be turned ON at Sunset and turn OFF at Sunrise, based on the Timezone. The code below works for me, but needs integration to the current hack. It only needs the location code and could be input as the same as what is done with the Timezone,.

At the moment, the ON/OFF threshold for the IR leds is quite unreliable. Is there an access to a threshold value or is everything hardware? If software accessible, a 0-100% slider to adjust the threshold sensitivity could also work nicely.

#!/bin/bash

# First obtain a location code from: https://weather.codes/search/

# Insert your location. For example CAXX0454 is a location code for Sherbrooke, Qc, Canada
location="CAXX0454"
tmpfile=/tmp/$location.out

# Obtain sunrise and sunset raw data from weather.com
wget -q "https://weather.com/weather/today/l/$location" -O "$tmpfile"

SUNR=$(grep SunriseSunset "$tmpfile" | grep -oE '((1[0-2]|0?[1-9]):([0-5][0-9]) ?([AaPp][Mm]))' | head -1)
SUNS=$(grep SunriseSunset "$tmpfile" | grep -oE '((1[0-2]|0?[1-9]):([0-5][0-9]) ?([AaPp][Mm]))' | tail -1)


sunrise=$(date --date="$SUNR" +%R)
sunset=$(date --date="$SUNS" +%R)

# Use $sunrise and $sunset variables to fit your needs. Example:
echo "Sunrise for location $location: $sunrise"
echo "Sunset for location $location: $sunset"`

https://weather.com/weather/today/l/CAXX0454
https://weather.codes/search/

Hostname: yi-96a0
Firmware Version: 0.3.0
Base Version: 12.0.35.8_202211241029
Model Suffix: y291ga

[roleoroleo]

This would be a great feature but I can't control the IR to stay on.
I can only disable it or enable it but when it is enabled the cam independently manages switching on and off based on the light.

[Meinadigitalworld]

Hi,

But that's what the code would do. If the actual time is between Sunrise and Sunset (Daytime), disable the "Enable IR led for night vision" , turn off the switch of the IR LED, like I do manually, but programmatically. If the actual time is between Sunset and Sunrise (Nightime), enable the "Enable IR led for night vision", turn ON the switch of the IR LED, like I do manually, but programmatically. It would run the code every minutes and Enable/Disable the "Enable IR led for night vision" as per the Sunsrise/Sunset.

Looking at scripts and config files, I think that would overwrite in the camera.conf the "IR=yes" to "IR=no" or vice versa, depending on the Sunrise/Sunset time, every minute.

'If current time is between Sunrise and Sunset then
IR=no`
Else
IR=yes
Endif

Are we understanding each other correctly? Thanks.

[roleoroleo]

You could create your own script and save it to /tmp/sd
Then you can schedule it with crontab in the "Configuration" page.

Some tip:

• Use a local language service that uses 24h time format, like https://weather.com/en-GB/weather/today/l/CAXX0454
• head is not supported, by the cam use awk 'NR==1 { print }'
• tail is supported or you can use awk 'END { print }'

The commands to switch the IR light are:

ipc_cmd -i ON
ipc_cmd -i OFF

These commands will also change camera.conf.

[Meinadigitalworld]

Thanks for your feedback. Challenge accepted! How would I get access to the date/time of the camera? I'm asking, because the

current_date=$(date "+%Y-%m-%d %Z")
current_time=$(date "+%H:%M %Z")

are retuning the system date/time in GMT format, not the date/time shown by the camera.

Would like to add this to the crontab, but would you have to path to it? Thanks.

'1 0 * * * rm -f /tmp/sd/SunValues.txt'
'* * * * * /tmp/sd/Sunrise.sh'

[roleoroleo]

Read the config file:

#!/bin/sh

CONF_FILE="etc/system.conf"
YI_HACK_PREFIX="/tmp/sd/yi-hack"

get_config()
{
    key=$1
    grep -w $1 $YI_HACK_PREFIX/$CONF_FILE | cut -d "=" -f2
}

export TZ=$(get_config TIMEZONE)
current_date=$(date "+%Y-%m-%d %Z")
current_time=$(date "+%H:%M %Z")

Would like to add this to the crontab, but would you have to path to it? Thanks.

What do you mean?

[Meinadigitalworld]

Hi,

Thanks for the information. I'm a not a top gun programmer and was just wondering how I can vi to the Crontab to put my two lines.

Below is the code that I have programmed. It is not perfect, but for my skills, it does the work. I have decided to compare UTC all the time. I might change it as per your last instructions. Here is what I have. Your feedback would be appreciated.

Are they any other control of the Night Time LEDs other than the switch? I'm asking, because even when it is turned on/off manually, when set to OFF, the camera will try to switch from somewhat ON/OFF for about 10 minutes, every 30 seconds. Like if it sees its dark, but not dark, dark, but not dark... I will upload a picture later. A picture is worth a thousand words! Thanks.

# Obtain a location code from: https://weather.codes/search/
# Insert your location. For example CAXX0454 is a location code for Sherbrooke, Qc, Canada
# Make sure that you are using the 24H format, as this code only works with 24H time.
# Add this line to the Crontab so that it deletes the SunValues.txt file every 24H: 1 0 * * * rm -f /tmp/sd/SunValues.txt
# Add this line to the Crontab so that the Sunrise.sh gets executed every minute: * * * * * /tmp/sd/Sunrise.sh 

location="CAXX0454"
tmpfile="/tmp/$location.out"

# Initialize variables
IP="weather.com" # Site to be pinged
COUNT=1 # Number of ping attempts
SunValuesFileExist=0 # Does the /tmp/sd/SunValuesSubValues.txt file exist 1 = Yes

# Testing if the SunValues.txt file exists, not to pull data from Weather.com every minute.
if [ -e /tmp/sd/SunValues.txt ]; then
    SunValuesFileExist=1
else
    SunValuesFileExist=0
fi

# Function to turn ON/OFF the Night Vision IR Light
NightVisionIRLight() {
# Checks if the current timestamp is between the sunrise and sunset timestamps
	date=$(date +%s)
    if [ "$date" -ge "$SUNR_UTC" ] && [ "$date" -le "$SUNS_UTC" ]; then
       ipc_cmd -i OFF
       echo "The current time is between sunrise and sunset. Setting the 'Night Vision IR Light = OFF'"
    else
       ipc_cmd -i ON
       echo "The current time is outside the sunrise and sunset. Setting the 'Night Vision IR Light = ON'"
    fi

	PrintResults
}

# Function to print all the variables
PrintResults() {
	local SUNR_UTC_Readable=$(date -ud "@$SUNR_UTC" "+%a %b %d %T %Z %Y")  # Convert Sunrise UTC timestamp to readable date and time
	local SUNS_UTC_Readable=$(date -ud "@$SUNS_UTC" "+%a %b %d %T %Z %Y")  # Convert Sunset UTC timestamp to readable date and time
	echo "Sunrise/Sunset for location $location:"
    echo "Sunrise Local: Date: $SUNR_DATE, Time: $SUNR_TIME"
	echo "Sunset Local : Date: $SUNR_DATE, Time: $SUNS_TIME"
	echo "Offset UTC   : $OFFSET_UTC"
	echo "Sunrise UTC  : $SUNR_UTC_Readable"
	echo "Sunset UTC   : $SUNS_UTC_Readable"
	echo "Current UTC  : $(date)"
	echo "SunValuesExist = $SunValuesFileExist"
}

# Function to read values from SunValues.txt to variables
SunValuesRead() {
	SUNR_DATE=$(grep "Date=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNR_TIME=$(grep "SunriseTimeLocal=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNS_TIME=$(grep "SunsetTimeLocal=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	OFFSET_UTC=$(grep "OffsetUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNR_UTC=$(grep "SunriseTimeUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNS_UTC=$(grep "SunsetTimeUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
}

# Main Routine
if [ $SunValuesFileExist -eq 1 ]; then
    SunValuesRead        
    NightVisionIRLight
else
    ping -c $COUNT $IP > /dev/null 2>&1
    if [ $? -eq 0 ]; then
        echo "Ping to $IP was successful."
        # Downloading the web page content from weather.com for the specified location code to a tmpfile
        wget -q --no-check-certificate "https://weather.com/weather/today/l/$location" -O "$tmpfile"

        # Findind Sunrise and Sunset data from the tmpfile (Local and UTC)
		SUNR=$(grep -oE '"sunriseTimeLocal":\["[^"]+"' "$tmpfile" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[+-][0-9]{4}')
		SUNS=$(grep -oE '"sunsetTimeLocal":\["[^"]+"' "$tmpfile" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[+-][0-9]{4}')
		SUNR_UTC=$(grep -oE '"sunriseTimeUtc":\[[0-9]+' "$tmpfile" | grep -oE '[0-9]+' | sed -n '1p')
        SUNS_UTC=$(grep -oE '"sunsetTimeUtc":\[[0-9]+' "$tmpfile" | grep -oE '[0-9]+' | sed -n '1p')

        # Uncomment these two lines if the search in tmpfile stops to work. They may have changed the wording of the HTML code.
        output_file="$(dirname "$0")/Output.txt"
        cat "$tmpfile" > "$output_file"

        SUNR_DATE=${SUNR:0:10}
        SUNR_TIME=${SUNR:11:5}
        SUNS_TIME=${SUNS:11:5}
		OFFSET_UTC=${SUNR:19:5}

        # Check if the length of the extracted values is as expected before writing them to the SunValues.txt file
        if [ ${#SUNR_DATE} -eq 10 ] && [ ${#SUNR_TIME} -eq 5 ] && [ ${#SUNS_TIME} -eq 5 ] && [ ${#SUNR_UTC} -eq 10 ] && [ ${#SUNS_UTC} -eq 10 ]; then
            # Writing the values to the SunValues.txt file
            echo "Date=$SUNR_DATE" > /tmp/sd/SunValues.txt
            echo "SunriseTimeLocal=$SUNR_TIME" >> /tmp/sd/SunValues.txt
            echo "SunsetTimeLocal=$SUNS_TIME" >> /tmp/sd/SunValues.txt
			echo "OffsetUTC=$OFFSET_UTC" >> /tmp/sd/SunValues.txt
            echo "SunriseTimeUTC=$SUNR_UTC" >> /tmp/sd/SunValues.txt
            echo "SunsetTimeUTC=$SUNS_UTC" >> /tmp/sd/SunValues.txt
            
            NightVisionIRLight
        else
            echo "Error: Extracted values from $IP are not as expected. Not creating SunValues.txt."
            echo "Enable the Output.txt lines in the script for diagnostic."
			echo "Sunrise Local Date: $SUNR_DATE"
            echo "Sunrise Local Time: $SUNR_TIME"
            echo "Sunset Local Time: $SUNS_TIME"
            echo "Sunrise UTC: $SUNR_UTC"
            echo "Sunset UTC: $SUNS_UTC"
        fi
    else
        echo "Error: Ping to $IP failed."
        echo "The SunValues.txt file does not exist and Internet access unavailable. No change to IR Night Switch"
    fi
fi

[roleoroleo]

The script seems ok. Let me know if it works properly.

Are they any other control of the Night Time LEDs other than the switch?

No, unfortunately no.

[Meinadigitalworld]

Hi,

It is working perfectly. You did not try it yourself?

Then you can schedule it with crontab in the "Configuration" page.

That's the part that I did not understand until this right minute! Did not notice that you could execute crontab commands right in the "Configuration" page of the camera itself! Since the system time is UTC, if I want to execute a Crontab task at midnight, would I need to account for the UTC offset? My offset at the moment is -0400. Would that mean that the task needs to be added for 4AM? We are EDT -0400 at the moment and will be EST -0500 in November. Will I need to change that in November?

I could venture myself, if you allow me, to design something similar as what you have designed for the Timezone.

I would add, under the "Configuration/General" section or "Camera Settings/General" (Your call), an input field to write the location code and a web link "https://weather.codes/search/", where the people would find the code and paste it down to the input field. I would also add a switch "Sunrise/Sunset" that would say "Enable/disable Sunrise/Sunset (if you select this option, this will override the IR led switch for night vision and precisely follow the Sunrise/Sunset for your region location code)." Would you guide me on that? Where is the html code?

Thanks!

[roleoroleo]

It is working perfectly. You did not try it yourself?

No, at the moment.

crontab works in local time (if I remember correctly), so you don't have to change the schedule.
But it's not completely clear to me what happens when dst changes.

All html/js/css/cgi-code is in the www folder.
It's very simple, I'm not a good web programmer.

[Meinadigitalworld]

Hi,

Thanks for the information.

Well I said "It is working perfectly", until I have it executed by the crontab. If I ssh to the camera and run the Sunrise.sh script manually, the SunValues.txt gets created. If the crontab executes the Sunrise.sh, SunValues.txt does not get created... crontab is new to me. Any idea?

I have decided to manage for myself the deletion of the SunValues.txt file every 24 hours, instead of crontab. For HH:MM, when MM = 00, I check if HH =01, for 1AM. It did delete the SunValues.txt file at 1AM, but never got created ever after, even if the Sunrise.sh gets executed every minutes. When I run it manually, it gets created...

# Reading the camera time to delete the SunValues.txt file at 1AM, verified at the hour.
if [ $current_minutes -eq 00 ]; then
    	CONF_FILE="etc/system.conf"
		YI_HACK_PREFIX="/tmp/sd/yi-hack"

		get_config()
		{
			key=$1
			grep -w $1 $YI_HACK_PREFIX/$CONF_FILE | cut -d "=" -f2
		}

		export TZ=$(get_config TIMEZONE)
		#current_date=$(date "+%Y-%m-%d %Z")
		current_date=$(date "+%Y-%m-%d")
		current_time_HH=$(date "+%H")
		
		if [ $current_time_HH -eq 01 ]; then
			echo "File deleted"
			rm -f /tmp/sd/SunValues.txt
		fi
fi

I also added a verification for the location code, to test that it is valid. Here is my most recent code:

#!/bin/bash

# Obtain a location code from: https://weather.codes/search/
# Insert your location. For example CAXX0454 is a location code for Sherbrooke, Qc, Canada
# Make sure that you are using the 24H format, as this code only works with 24H time.
# Add this line to the Crontab so that the Sunrise.sh gets executed every minute: * * * * * /tmp/sd/Sunrise.sh 

echo "The script was executed at $(date)" > /tmp/sd/Sunrise.log
#echo "This is a test to create a .txt file" > /tmp/sd/Test.log

location="CAXX0454"
tmpfile="/tmp/$location.out"

# Initialize variables
IP="weather.com" # Site to be pinged
COUNT=1 # Number of ping attempts
SunValuesFileExist=0 # Does the /tmp/sd/SunValuesSubValues.txt file exist 1 = Yes

# Get the current system time and extract the minutes (MM) part
current_minutes=$(date "+%M")

# Function to turn ON/OFF the Night Vision IR Light
NightVisionIRLight() {
# Checks if the current timestamp is between the sunrise and sunset timestamps
	#unset TZ #Forcing UTC, as the if statement "Reading the camera time" changes the date instruction to local
	date=$(date +%s)
    if [ "$date" -ge "$SUNR_UTC" ] && [ "$date" -le "$SUNS_UTC" ]; then
       ipc_cmd -i OFF
       echo "The current time is between sunrise and sunset. Setting the 'Night Vision IR Light = OFF'"
    else
       ipc_cmd -i ON
       echo "The current time is outside the sunrise and sunset. Setting the 'Night Vision IR Light = ON'"
    fi

	PrintResults
}

# Function to print all the variables
PrintResults() {
	local SUNR_UTC_Readable=$(date -ud "@$SUNR_UTC" "+%a %b %d %T %Z %Y")  # Convert Sunrise UTC timestamp to readable date and time
	local SUNS_UTC_Readable=$(date -ud "@$SUNS_UTC" "+%a %b %d %T %Z %Y")  # Convert Sunset UTC timestamp to readable date and time
	echo "Sunrise/Sunset for location $location:"
    echo "Sunrise Local: Date: $SUNR_DATE, Time: $SUNR_TIME"
	echo "Sunset Local : Date: $SUNR_DATE, Time: $SUNS_TIME"
	echo "Offset UTC   : $OFFSET_UTC"
	echo "Sunrise UTC  : $SUNR_UTC_Readable"
	echo "Sunset UTC   : $SUNS_UTC_Readable"
	echo "Current UTC  : $(date)"
	echo "SunValuesExist = $SunValuesFileExist"
}

# Function to read values from SunValues.txt to variables
SunValuesRead() {
	SUNR_DATE=$(grep "Date=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNR_TIME=$(grep "SunriseTimeLocal=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNS_TIME=$(grep "SunsetTimeLocal=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	OFFSET_UTC=$(grep "OffsetUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNR_UTC=$(grep "SunriseTimeUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNS_UTC=$(grep "SunsetTimeUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
}

# Reading the camera time to delete the SunValues.txt file at 1AM, verified at the hour.
if [ $current_minutes -eq 00 ]; then
    	CONF_FILE="etc/system.conf"
		YI_HACK_PREFIX="/tmp/sd/yi-hack"

		get_config()
		{
			key=$1
			grep -w $1 $YI_HACK_PREFIX/$CONF_FILE | cut -d "=" -f2
		}

		export TZ=$(get_config TIMEZONE)
		#current_date=$(date "+%Y-%m-%d %Z")
		current_date=$(date "+%Y-%m-%d")
		current_time_HH=$(date "+%H")
		
		if [ $current_time_HH -eq 01 ]; then
			echo "File deleted"
			rm -f /tmp/sd/SunValues.txt
		fi
fi

# Testing if the SunValues.txt file exists, not to pull data from Weather.com every minute.
if [ -e /tmp/sd/SunValues.txt ]; then
    SunValuesFileExist=1
else
    SunValuesFileExist=0
fi


# Main Routine
if [ $SunValuesFileExist -eq 1 ]; then
    SunValuesRead        
    NightVisionIRLight
else
    ping -c $COUNT $IP > /dev/null 2>&1
	if [ $? -eq 0 ]; then
		echo "Ping to $IP was successful."
		wget --spider "https://weather.com/weather/today/l/$location" > /dev/null 2>&1
		if [ $? -eq 0 ]; then
			# Downloading the web page content from weather.com for the specified location code to a tmpfile
			wget -q --no-check-certificate "https://weather.com/weather/today/l/$location" -O "$tmpfile"

			# Findind Sunrise and Sunset data from the tmpfile (Local and UTC)
			SUNR=$(grep -oE '"sunriseTimeLocal":\["[^"]+"' "$tmpfile" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[+-][0-9]{4}')
			SUNS=$(grep -oE '"sunsetTimeLocal":\["[^"]+"' "$tmpfile" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[+-][0-9]{4}')
			SUNR_UTC=$(grep -oE '"sunriseTimeUtc":\[[0-9]+' "$tmpfile" | grep -oE '[0-9]+' | sed -n '1p')
			SUNS_UTC=$(grep -oE '"sunsetTimeUtc":\[[0-9]+' "$tmpfile" | grep -oE '[0-9]+' | sed -n '1p')

			# Uncomment these two lines if the search in tmpfile stops to work. They may have changed the wording of the HTML code.
			#output_file="$(dirname "$0")/Output.txt"
			#cat "$tmpfile" > "$output_file"

			SUNR_DATE=${SUNR:0:10}
			SUNR_TIME=${SUNR:11:5}
			SUNS_TIME=${SUNS:11:5}
			OFFSET_UTC=${SUNR:19:5}

			# Check if the length of the extracted values is as expected before writing them to the SunValues.txt file
			if [ ${#SUNR_DATE} -eq 10 ] && [ ${#SUNR_TIME} -eq 5 ] && [ ${#SUNS_TIME} -eq 5 ] && [ ${#SUNR_UTC} -eq 10 ] && [ ${#SUNS_UTC} -eq 10 ]; then
				# Writing the values to the SunValues.txt file
				echo "Date=$SUNR_DATE" > /tmp/sd/SunValues.txt
				echo "SunriseTimeLocal=$SUNR_TIME" >> /tmp/sd/SunValues.txt
				echo "SunsetTimeLocal=$SUNS_TIME" >> /tmp/sd/SunValues.txt
				echo "OffsetUTC=$OFFSET_UTC" >> /tmp/sd/SunValues.txt
				echo "SunriseTimeUTC=$SUNR_UTC" >> /tmp/sd/SunValues.txt
				echo "SunsetTimeUTC=$SUNS_UTC" >> /tmp/sd/SunValues.txt
				echo "File SunValues.txt was created on $(date)" > /tmp/sd/SunValues.log
				NightVisionIRLight
			else
				echo "Error: Extracted values from $IP are not as expected. Not creating SunValues.txt."
				echo "Enable the Output.txt lines in the script for diagnostic."
				echo "Sunrise Local Date: $SUNR_DATE"
				echo "Sunrise Local Time: $SUNR_TIME"
				echo "Sunset Local Time: $SUNS_TIME"
				echo "Sunrise UTC: $SUNR_UTC"
				echo "Sunset UTC: $SUNS_UTC"
			fi
		else
			echo "Error: It appears that your $location code is not valid."
			echo "Obtain a valid location code from: https://weather.codes/search/"
		fi
	else
		echo "Error: Ping to $IP failed."
		echo "The SunValues.txt file does not exist and Internet access unavailable. No change to IR Night Switch"
	fi
fi

[roleoroleo]

What's your crontab string to start the process?

[Meinadigitalworld]

Hi,

* * * * * /tmp/sd/Sunrise.sh

If you look at the script, it does create the Sunrise.log file without any issue, but it can never create the SunValues.txt. Does the below credentials gives you a clue on something? Thanks.

root@yi-96a0:/# ls -ld /tmp/sd
drwxr-xr-x    7 root     root         32768 Mar 20 18:19 /tmp/sd
root@yi-96a0:/# ls -l /tmp/sd
drwxr-xr-x    2 root     root         32768 Aug 21  2023 Factory.done
-rwxr-xr-x    1 root     root            63 Mar 20 18:19 SunValues.log
-rwxr-xr-x    1 root     root           128 Mar 20 18:19 SunValues.txt
-rwxr-xr-x    1 root     root            56 Mar 20 18:20 Sunrise.log
-rwxr-xr-x    1 root     root          6209 Mar 20 18:19 Sunrise.sh
drwxr-xr-x    2 root     root         32768 Jan 13 19:58 System Volume Information
drwxr-xr-x    2 root     root         32768 Jan  1  1980 backup
-rwxr-xr-x    1 root     root          5698 Feb 21  2023 lower_half_init.sh
drwxr-xr-x    2 root     root         32768 Mar  9 16:40 record
-rwxr-xr-x    1 root     root      67108864 Jan 14 00:44 swapfile
-rwxr-xr-x    1 root     root           284 Mar 17 00:43 test.sh
drwxr-xr-x   10 root     root         32768 Oct 27 06:33 yi-hack
root@yi-96a0:/#

[roleoroleo]

Well I said "It is working perfectly", until I have it executed by the crontab. If I ssh to the camera and run the Sunrise.sh script manually, the SunValues.txt gets created. If the crontab executes the Sunrise.sh, SunValues.txt does not get created... crontab is new to me. Any idea?

I tested it and the file SunValues.txt is properly created inside the /tmp/sd folder
Here the content:

Date=2024-03-21
SunriseTimeLocal=06:47
SunsetTimeLocal=19:02
OffsetUTC=-0400
SunriseTimeUTC=1711018061
SunsetTimeUTC=1711062136

[Meinadigitalworld]

Hi,

Most probably, you did run the script at the terminal, right? /tmp/sd/Sunrise.sh. That works fine.

Set the Sunrise.sh file to the Crontab to be executed every minute and delete the SunValues.txt and SunValues.log files. You will see that they do not get created by the Crontab once deleted.

[roleoroleo]

Most probably, you did run the script at the terminal, right? /tmp/sd/Sunrise.sh. That works fine.

No, I didn't run the script manually.
Try to change /bin/bash with /bin/sh in the 1st line.

[Meinadigitalworld]

Hi,

Well that was an interesting one...

Try to change /bin/bash with /bin/sh in the 1st line.

That did not change anything. I have then changed the crontab line to * * * * * /tmp/sd/Sunrise.sh > /tmp/sd/SunriseResults.log 2>&1 and got this as a result:

Error: It appears that your CAXX0454 code is not valid.
Obtain a valid location code from: https://weather.codes/search/

Therefore, it means that when the crontab runs the Sunrise.sh script, the if statement returns FALSE, which is not the case at the terminal prompt. The wget must be the cause in a crontab environment, but why not in your environment?

wget --spider "https://weather.com/weather/today/l/$location" > /dev/null 2>&1
if [ $? -eq 0 ]; then

What ended up working for me is giving the full path of the wget command. But, still not cleat to me as there is another wget that I did not add the full path and it is working fine...

/tmp/sd/yi-hack/usr/bin/wget --spider "https://weather.com/weather/today/l/$location" > /dev/null 2>&1`

Any how, I did change the code to correct a recent find. I was creating the SunValues.txt at 1AM local time. The Weather.com was not necessary yet updated to the next day Sunrise/Sunset. I decided to pull the data every hour. Here is the latest code.

#!/bin/bash

# Obtain a location code from: https://weather.codes/search/
# Insert your location. For example CAXX0454 is a location code for Sherbrooke, Qc, Canada
# Make sure that you are using the 24H format, as this code only works with 24H time.
# Add this line to the Crontab so that the Sunrise.sh gets executed every minute: * * * * * /tmp/sd/Sunrise.sh > /tmp/sd/SunriseResults.log 2>&1 

location="CAXX0454"
url_Location="https://weather.com/weather/today/l/$location"
tmpfile="/tmp/$location.out"

# Initialize variables
IP="weather.com" # Site to be pinged
COUNT=1 # Number of ping attempts
LocationValid=0 # Does the location code is valid 1 = Yes

# Get the current system time and extract the minutes (MM) part
current_minutes=$(date "+%M")

# Function to test if the location code is valid
ValidateLocationCode() { 
	# Make a GET request to the URL and store the HTTP response code
	http_code=$(/tmp/sd/yi-hack/usr/bin/wget --server-response --spider "$url_Location" 2>&1 | awk '/^  HTTP/{print $2}')

	# Check if the HTTP response code indicates success (200)
	if [ "$http_code" == "200" ]; then
		LocationValid=1
	else
		LocationValid=0
	fi
}

# Function to read values from SunValues.txt to variables
SunValuesRead() {
	SUNR_DATE=$(grep "Date=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNR_TIME=$(grep "SunriseTimeLocal=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNS_TIME=$(grep "SunsetTimeLocal=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	OFFSET_UTC=$(grep "OffsetUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNR_UTC=$(grep "SunriseTimeUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	SUNS_UTC=$(grep "SunsetTimeUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
}

# Function to print all the variables
PrintResults() {
	local SUNR_UTC_Readable=$(date -ud "@$SUNR_UTC" "+%a %b %d %T %Z %Y")  # Convert Sunrise UTC timestamp to readable date and time
	local SUNS_UTC_Readable=$(date -ud "@$SUNS_UTC" "+%a %b %d %T %Z %Y")  # Convert Sunset UTC timestamp to readable date and time
	echo "Sunrise/Sunset for location $location:"
    echo "Sunrise Local: Date: $SUNR_DATE, Time: $SUNR_TIME"
	echo "Sunset Local : Date: $SUNR_DATE, Time: $SUNS_TIME"
	echo "Offset UTC   : $OFFSET_UTC"
	echo "Sunrise UTC  : $SUNR_UTC_Readable"
	echo "Sunset UTC   : $SUNS_UTC_Readable"
	echo "Current UTC  : $(TZ=UTC date)"
}

# Function to create the SunValues.txt file.
SunValuesCreate() {
	ping -c $COUNT $IP > /dev/null 2>&1
	if [ $? -eq 0 ]; then
		echo "Ping to $IP was successful. Internet access is available."
		ValidateLocationCode
		#echo "$location"
		if [ $LocationValid -eq 1 ]; then			
			echo "The location code $location exist"
			# Downloading the web page content from weather.com for the specified location code to a tmpfile
			wget -q "https://weather.com/weather/today/l/$location" -O "$tmpfile"

			# Findind Sunrise and Sunset data from the tmpfile (Local and UTC)
			SUNR=$(grep -oE '"sunriseTimeLocal":\["[^"]+"' "$tmpfile" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[+-][0-9]{4}')
			SUNS=$(grep -oE '"sunsetTimeLocal":\["[^"]+"' "$tmpfile" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}[+-][0-9]{4}')
			SUNR_UTC=$(grep -oE '"sunriseTimeUtc":\[[0-9]+' "$tmpfile" | grep -oE '[0-9]+' | sed -n '1p')
			SUNS_UTC=$(grep -oE '"sunsetTimeUtc":\[[0-9]+' "$tmpfile" | grep -oE '[0-9]+' | sed -n '1p')

			# Uncomment these two lines if the search in tmpfile stops to work. They may have changed the wording of the HTML code.
			#output_file="$(dirname "$0")/Output.txt"
			#cat "$tmpfile" > "$output_file"

			SUNR_DATE=${SUNR:0:10}
			SUNR_TIME=${SUNR:11:5}
			SUNS_TIME=${SUNS:11:5}
			OFFSET_UTC=${SUNR:19:5}

			# Check if the length of the extracted values is as expected before writing them to the SunValues.txt file
			if [ ${#SUNR_DATE} -eq 10 ] && [ ${#SUNR_TIME} -eq 5 ] && [ ${#SUNS_TIME} -eq 5 ] && [ ${#SUNR_UTC} -eq 10 ] && [ ${#SUNS_UTC} -eq 10 ]; then
				# Writing the values to the SunValues.txt file
				echo "Date=$SUNR_DATE" > /tmp/sd/SunValues.txt
				echo "SunriseTimeLocal=$SUNR_TIME" >> /tmp/sd/SunValues.txt
				echo "SunsetTimeLocal=$SUNS_TIME" >> /tmp/sd/SunValues.txt
				echo "OffsetUTC=$OFFSET_UTC" >> /tmp/sd/SunValues.txt
				echo "SunriseTimeUTC=$SUNR_UTC" >> /tmp/sd/SunValues.txt
				echo "SunsetTimeUTC=$SUNS_UTC" >> /tmp/sd/SunValues.txt
				echo "File SunValues.txt was created on $(date)" > /tmp/sd/SunValues.log
			else
				echo "Error: Extracted values from $IP are not as expected. Not creating SunValues.txt."
				echo "Enable the Output.txt lines in the script for diagnostic."
				echo "Sunrise Local Date: $SUNR_DATE"
				echo "Sunrise Local Time: $SUNR_TIME"
				echo "Sunset Local Time: $SUNS_TIME"
				echo "Sunrise UTC: $SUNR_UTC"
				echo "Sunset UTC: $SUNS_UTC"
			fi
		else
			echo "Error: It appears that your $location code is not valid."
			echo "Obtain a valid location code from: https://weather.codes/search/"
		fi
	else
		echo "Error: Ping to $IP failed. Check your Internet Connection."
	fi
}

# Function to turn ON/OFF the Night Vision IR Light
NightVisionIRLight() {
# Checks if the current timestamp is between the sunrise and sunset timestamps
	date=$(date +%s)
    if [ "$date" -ge "$SUNR_UTC" ] && [ "$date" -le "$SUNS_UTC" ]; then
       ipc_cmd -i OFF
       echo "The current time is between sunrise and sunset. Setting the 'Night Vision IR Light = OFF'"
    else
       ipc_cmd -i ON
       echo "The current time is outside the sunrise and sunset. Setting the 'Night Vision IR Light = ON'"
    fi
}

# To create or refresh the SunValues.txt. Refreshed every hour, as the Weather.com Sunrise/Sunset may not be up to date at time of pulling.
if [ -e /tmp/sd/SunValues.txt ]; then
	if [ $current_minutes -eq 00 ]; then
		SunValuesCreate
	fi
else
	SunValuesCreate
fi

#  
if [ -e /tmp/sd/SunValues.txt ]; then
    SunValuesRead
    NightVisionIRLight
	PrintResults
else
	echo "Error: The SunValues.txt file does not exist. No change to IR Night Switch."
	echo "They may have changed the wording of the HTML code."
fi

[roleoroleo]

Pay attention, there are 2 wget in the system.

[Meinadigitalworld]

Hi,

Not quite sure about the "be careful" notice. Could you explain it to me more?

Yes, I have noticed that there were two places: /usr/bin/wget, and /tmp/sd/yi-hack/usr/bin/wget. That's why I ended up putting the full path to see what it would do good for me. It seems that the yi-hack path has the most recent wget command version.

[Meinadigitalworld]

Hi,

I have decided to change the code, as the data provided for the Sunrise/Sunset from Weather.com does not get updated on a daily basis. They provide 7 days Sunrise/Sunset information, but I thought that they were shifting the information everyday. That is not the case. It can sit there for a few days without getting updated, at least for the Sunrise/Sunset information.

Therefore, I've changed the code to build a 7 days array where I pull out the information based on the camera date/time. Below is the final version.

I have updated the HTML code, but I was wondering if I was going any further with it. If I'm putting the work to update everything up, is this something that you would implement in a later release? If so, I would work on it, but if not, I can live with the hard coded location code in the script.

Also, if I do my own modifications, it means that I will no longer be able to do firmware upgrades, as my modifications will be overridden by yours with a firmware upgrade.

I have also noticed that the IR Switch is only for the IR cut filter. The light sensor is still controlling the IR LEDs, based on the light it receives. This is totally annoying!!! That is my understanding. It would be nice to have control of the LEDs itself... The only way I see is to modify the PCB circuit so that when the IR cut filter is ON, cut power to the IR LEDs. A simple NPN transistor would probably do the job. Just curious: "Do you have that expertise?" Maybe someone who reads this thread may have an idea for a circuit, feel free to join.

#!/bin/bash

# Version 1.0 - Initial Release, 2024-03-31
# Obtain a location code from: https://weather.codes/search/
# Insert your location. For example CAXX0454 is a location code for Sherbrooke, Qc, Canada
# Make sure that you are using the 24H format, as this code only works with 24H time.
# You need an Internet connection for this script to work.
# Add this line to the Crontab so that the Sunrise.sh gets executed every minute: * * * * * /tmp/sd/Sunrise.sh > /tmp/sd/SunriseResults.log 2>&1 

location="CAXX0454"
url_Location="https://weather.com/weather/today/l/$location"
tmpfile="/tmp/$location.out"

# Initialize variables
IP="weather.com" # Site to be pinged
COUNT=1 # Number of ping attempts
location_valid=0 # Is the location code valid? 1 = Yes

# Get the current system time and extract the minutes part
current_minutes=$(date "+%M")

# Reading the camera time.
CONF_FILE="etc/system.conf"
YI_HACK_PREFIX="/tmp/sd/yi-hack"

get_config()
{
	key=$1
	grep -w $1 $YI_HACK_PREFIX/$CONF_FILE | cut -d "=" -f2
}

export TZ=$(get_config TIMEZONE)
current_cam_date=$(date "+%Y-%m-%d %H:%M:%S %Z")
current_cam_YMD=$(date "+%Y-%m-%d")
current_cam_HH=$(date "+%H")

# Every 60 minutes, verifying if it is 1AM to delete SunValues.txt/.log
if [ $current_minutes -eq 00 ]; then		
		if [ $current_cam_HH -eq 01 ]; then
			echo "File deleted"
			rm -f /tmp/sd/SunValues.txt
			rm -f /tmp/sd/SunValues.log
		fi
fi

# Function to test if the location code is valid
ValidateLocationCode() { 
	# Make a GET request to the URL and store the HTTP response code
	http_code=$(/tmp/sd/yi-hack/usr/bin/wget --server-response --spider "$url_Location" 2>&1 | awk '/^  HTTP/{print $2}')

	# Check if the HTTP response code indicates success (200)
	if [ "$http_code" == "200" ]; then
		location_valid=1
		echo "The location code $location exist."
	else
		location_valid=0
	fi
}

# Function to read values from SunValues.txt to variables
SunValuesRead() {
	sunrise=$(grep "SunriseUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	sunset=$(grep "SunsetUTC=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	sunrise_epoch=$(grep "SunriseEpoch=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
	sunset_epoch=$(grep "SunsetEpoch=" /tmp/sd/SunValues.txt | cut -d'=' -f2)
}

# Function to print all the variables
PrintResults() {
	echo "Sunrise/Sunset for location $location:"
	echo "Sunrise Local    : $sunrise"
	echo "Sunset Local     : $sunset"
	echo "Camera date/time : $current_cam_date"
}

# Function to create the SunValues.txt file.
SunValuesCreate() {
	ping -c $COUNT $IP > /dev/null 2>&1
	if [ $? -eq 0 ]; then
		echo "Ping to $IP was successful. Internet access is available."
		ValidateLocationCode
		if [ $location_valid -eq 1 ]; then			
			echo "DATA scraping from $url_Location in progress..."
			# Downloading the web page content from weather.com for the specified location code to a tmpfile
			/tmp/sd/yi-hack/usr/bin/wget -q --no-check-certificate "https://weather.com/weather/today/l/$location" -O "$tmpfile"

			# Store the HTML code to file for references.
			output_file="$(dirname "$0")/Output.txt"
			cat "$tmpfile" > "$output_file"
			
			echo "DATA parsing in progress... "
			
			# Buiding an array from the tmpfile to extract the ISO dates, Sunrise and Sunset (ISO 8601).
			sunrise_local_array=$(grep -m 1 -o '"sunriseTimeLocal":\[[^]]*\]' "$tmpfile" | sed -n '1 s/"sunriseTimeLocal":\[\([^]]*\)\]/\1/p' | tr ',' '\n' | sed 's/"//g')
			sunset_local_array=$(grep -m 1 -o '"sunsetTimeLocal":\[[^]]*\]' "$tmpfile" | sed -n '1 s/"sunsetTimeLocal":\[\([^]]*\)\]/\1/p' | tr ',' '\n' | sed 's/"//g')
			
			# Buiding an array from the tmpfile to extract the Epoch timestamps, Sunrise and Sunset (UTC).
			sunrise_epoch_array=$(grep -o '"sunriseTimeUtc":\[[^]]*\]' "$tmpfile" | awk 'NR==1 {print; exit}' | sed 's/"sunriseTimeUtc":\[\([^]]*\)\]/\1/g; s/\[//g; s/,/\n/g; s/]//g')
			sunset_epoch_array=$(grep -o '"sunsetTimeUtc":\[[^]]*\]' "$tmpfile" | awk 'NR==1 {print; exit}' | sed 's/"sunsetTimeUtc":\[\([^]]*\)\]/\1/g; s/\[//g; s/,/\n/g; s/]//g')

			# Converting the Epoch timestamps from the array to readable dates, Sunrise and sunset
			sunrise_readable_dates=$(echo "$sunrise_epoch_array" | while IFS= read -r sunrise_epoch_array; do date -d "@$sunrise_epoch_array" "+%Y-%m-%d %H:%M:%S %Z"; done)
			sunset_readable_dates=$(echo "$sunset_epoch_array" | while IFS= read -r sunset_epoch_array; do date -d "@$sunset_epoch_array" "+%Y-%m-%d %H:%M:%S %Z"; done)

			# Extract the line from the array that matches the camera date, Sunrise and Sunset (ISO 8601).
			SUNR=$(echo "$sunrise_local_array" | grep "$current_cam_YMD")
			SUNS=$(echo "$sunset_local_array" | grep "$current_cam_YMD")
						
			# Extract the line from the array that matches the camera date, Sunrise and Sunset (UTC).
			SUNR_UTC=$(echo "$sunrise_readable_dates" | grep "$current_cam_YMD")
			SUNS_UTC=$(echo "$sunset_readable_dates" | grep "$current_cam_YMD")

			# Converting the UTC date/time to Epoch, Sunrise and Sunset.
			SUNR_UTC_datetime=$(echo "$SUNR_UTC" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}')
			SUNS_UTC_datetime=$(echo "$SUNS_UTC" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}')
			SUNR_epoch=$(date -d "$SUNR_UTC_datetime" +%s)
			SUNS_epoch=$(date -d "$SUNS_UTC_datetime" +%s)
			
			# Check if the length of the extracted values are as expected before writing them to the SunValues.txt file
			if [ ${#SUNR_UTC} -eq 23 ] && [ ${#SUNS_UTC} -eq 23 ] && [ ${#SUNR_epoch} -eq 10 ] && [ ${#SUNS_epoch} -eq 10 ]; then
				# Writing the values to the SunValues.txt file
				echo "SunriseISO=$SUNR" > /tmp/sd/SunValues.txt
				echo "SunsetISO=$SUNS" >> /tmp/sd/SunValues.txt
				echo "SunriseUTC=$SUNR_UTC" >> /tmp/sd/SunValues.txt
				echo "SunsetUTC=$SUNS_UTC" >> /tmp/sd/SunValues.txt
				echo "SunriseEpoch=$SUNR_epoch" >> /tmp/sd/SunValues.txt
				echo "SunsetEpoch=$SUNS_epoch" >> /tmp/sd/SunValues.txt
				echo "File SunValues.txt was created on $(date)" > /tmp/sd/SunValues.log
			else
				echo "Error: Extracted values from $IP are not as expected. Not creating SunValues.txt."
				echo "Verify the content of the Output.txt file"
				echo "SunriseISO=$SUNR"
				echo "SunsetISO=$SUNS"
				echo "SunriseUTC=$SUNR_UTC"
				echo "SunsetUTC=$SUNS_UTC"
				echo "SunriseEpoch=$SUNR_epoch"
				echo "sunsetEpoch=$SUNS_epoch"
			fi
		else
			echo "Error: It appears that your $location code is not valid."
			echo "Obtain a valid location code from: https://weather.codes/search/"
		fi
	else
		echo "Error: Ping to $IP failed. Check your Internet Connection."
	fi
}

# Function to turn ON/OFF the Night Vision IR Light
NightVisionIRLight() {
    # Converting the camera date time to Epoch.
	current_cam_datetime=$(echo "$current_cam_date" | grep -oE '[0-9]{4}-[0-9]{2}-[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2}')
	current_cam_datetime_epoch=$(date -d "$current_cam_datetime" +%s)
	
	# Checks if the camera date/time is between the sunrise and sunset times.
	if [ "$current_cam_datetime_epoch" -ge "$sunrise_epoch" ] && [ "$current_cam_datetime_epoch" -le "$sunset_epoch" ]; then
		ipc_cmd -i OFF
		echo "The current camera date/time is within Sunrise and Sunset period."
		echo "Setting the 'Night Vision IR Light = OFF'."
	else
		ipc_cmd -i ON
		echo "The current camera date/time is outside the Sunrise and Sunset period."
		echo "Setting the 'Night Vision IR Light = ON'."
	fi
}

# To create the SunValues.txt if it does not exist.
if [ ! -e /tmp/sd/SunValues.txt ]; then
	SunValuesCreate
fi

# If the SunValues.txt exist, set the IR Switch according to Sunrise/Sunset.
if [ -e /tmp/sd/SunValues.txt ]; then
    SunValuesRead
    PrintResults
	NightVisionIRLight
fi

[roleoroleo]

I have updated the HTML code, but I was wondering if I was going any further with it. If I'm putting the work to update everything up, is this something that you would implement in a later release? If so, I would work on it, but if not, I can live with the hard coded location code in the script.

It would be a nice feature if you could actually turn night mode off and on completely.
I have never been asked for this specific feature.
So I wouldn't implement it within the hack.

Also, if I do my own modifications, it means that I will no longer be able to do firmware upgrades, as my modifications will be overridden by yours with a firmware upgrade.

No, you can add a startup.sh script to your sd card. The hack will run it after all other programs.
Check the last lines of system.sh
When you will upgrade the hack, the script remains.

I have also noticed that the IR Switch is only for the IR cut filter. The light sensor is still controlling the IR LEDs, based on the light it receives. This is totally annoying!!!

It should be the opposite: the ipc_cmd command (and the app) switches on/off the ir leds but (if I rembember correctly) IR filter continues to open/close based on the light.
If you switch on the option

the cam controls automatically leds and filter.
If you switch off the option, only leds remain off.
Isn't that your case?