Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget About-home #490

Closed
Quiddlee opened this issue Sep 3, 2024 · 0 comments Β· Fixed by #510
Closed

FSD: Widget About-home #490

Quiddlee opened this issue Sep 3, 2024 · 0 comments Β· Fixed by #510

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 3, 2024

πŸ“ Describe the refactoring task

Part of the issue #347
About-community component refactor

πŸ“ Code location

src/widgets/about/ui/about-community.tsx

βœ… Definition of Done (DoD):

  1. rename about.tsx component to about-community.tsx
  2. Refactor about-community.tsx's scss to scss modules including:
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer πŸ™…β€β™‚οΈ -> .trainer πŸ‘Œ.
  • and everything in your opinion that needs to be refactored
  1. move about-community.test.tsx to src/widgets/about-community/ui folder
  2. refactor JSX to utilize HTML5 tags
  3. re-export component as AboutCommunity
  4. rename image constant with image src to anything more meaningful
  5. add more descriptive alt attribute for the image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants