Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Alumni #499

Closed
Quiddlee opened this issue Sep 5, 2024 · 0 comments Β· Fixed by #501
Closed

FSD: Widget Alumni #499

Quiddlee opened this issue Sep 5, 2024 · 0 comments Β· Fixed by #501

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 5, 2024

πŸ“ Describe the refactoring task

Part of the issue #347
Alumni component refactor

πŸ“ Code location

src/widgets/alumni

βœ… Definition of Done (DoD):

  1. Refactor scss to scss modules as following:
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • rename all classes to be generic e.g .nodejs-trainer πŸ™…β€β™‚οΈ -> .trainer πŸ‘Œ.
  • and everything in your opinion that needs to be refactored
  1. delete AlumniProps type
  2. in the constants.ts remove type annotation from alumni and change it as following
const alumni = [...] as const
  1. move unit test inside the ui folder
  2. move all the magic numbers in the constants and place these constants inside the constants.ts folder
@Quiddlee Quiddlee added this to RS Site Sep 5, 2024
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 5, 2024
@Wystov Wystov self-assigned this Sep 6, 2024
@Wystov Wystov mentioned this issue Sep 6, 2024
2 tasks
@Wystov Wystov moved this from Backlog to Peer review in RS Site Sep 6, 2024
@Wystov Wystov moved this from Peer review to Review in RS Site Sep 7, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants