Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Communication #521

Closed
Quiddlee opened this issue Sep 13, 2024 · 0 comments Β· Fixed by #536
Closed

FSD: Widget Communication #521

Quiddlee opened this issue Sep 13, 2024 · 0 comments Β· Fixed by #536

Comments

@Quiddlee
Copy link
Member

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/communication

βœ… Definition of Done (DoD):

  1. Refactor communication.tsx's scss to scss modules
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored

communication.tsx

  1. rename RequiredProps to CommunicationProps
  2. change all the interfaces to types
  3. remove discord logo wrapper (use Image component directly)
  4. move communication.test.tsx to ui folder
  5. change test to not render Communication component with the same course on every test case.
@Quiddlee Quiddlee added this to RS Site Sep 13, 2024
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 13, 2024
@thirdmadman thirdmadman self-assigned this Sep 17, 2024
@thirdmadman thirdmadman moved this from Backlog to In Progress in RS Site Sep 17, 2024
@thirdmadman thirdmadman moved this from Peer review to Review in RS Site Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants