Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Contribute #523

Closed
Quiddlee opened this issue Sep 14, 2024 · 0 comments Β· Fixed by #601
Closed

FSD: Widget Contribute #523

Quiddlee opened this issue Sep 14, 2024 · 0 comments Β· Fixed by #601

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 14, 2024

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/contribute

βœ… Definition of Done (DoD):

  1. Refactor contribute.tsx's scss to scss modules
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored

contribute.tsx

  1. move contribute.test.tsx to ui folder
  2. replace div's with HTML5 tags
  3. give the imported image better name and change alt attribute to more descriptive
  4. remove OptionItem component. Move all the markup inside the contribute component instead
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 14, 2024
@Quiddlee Quiddlee added this to RS Site Sep 14, 2024
@Quiddlee Quiddlee added the good first issue Good for newcomers label Sep 25, 2024
@YulikK YulikK self-assigned this Sep 27, 2024
@YulikK YulikK moved this from Backlog to In Progress in RS Site Oct 10, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants