Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget OptionItem #524

Closed
Quiddlee opened this issue Sep 14, 2024 · 0 comments
Closed

FSD: Widget OptionItem #524

Quiddlee opened this issue Sep 14, 2024 · 0 comments

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 14, 2024

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/option-item

βœ… Definition of Done (DoD):

  1. Refactor option-item.tsx's scss to scss modules
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored

option-item.tsx

  1. move option-item.test.tsx to ui folder
  2. replace div with article
  3. remove export from props type
  4. remove props type re-export from index.ts
  5. remove all OptionItemProps from other components
  6. remove todo comment
  7. replace p tag with Paragraph
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 14, 2024
@Quiddlee Quiddlee added this to RS Site Sep 14, 2024
@Quiddlee Quiddlee added the good first issue Good for newcomers label Sep 23, 2024
@YulikK YulikK self-assigned this Sep 23, 2024
@YulikK YulikK moved this from Backlog to In Progress in RS Site Sep 23, 2024
@YulikK YulikK moved this from In Progress to Peer review in RS Site Sep 23, 2024
@KristiBo KristiBo mentioned this issue Sep 27, 2024
8 tasks
@github-project-automation github-project-automation bot moved this from Peer review to Done in RS Site Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants