Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget Courses #533

Closed
Quiddlee opened this issue Sep 17, 2024 · 0 comments Β· Fixed by #545
Closed

FSD: Widget Courses #533

Quiddlee opened this issue Sep 17, 2024 · 0 comments Β· Fixed by #545

Comments

@Quiddlee
Copy link
Member

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/courses

βœ… Definition of Done (DoD):

  1. Refactor courses.tsx's scss to scss modules
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored

courses.tsx

  1. move courses.test.tsx to ui folder
  2. rename other-courses.test.tsx to courses.test.tsx
@Quiddlee Quiddlee added this to RS Site Sep 17, 2024
@Quiddlee Quiddlee moved this to Backlog in RS Site Sep 17, 2024
@Quiddlee Quiddlee added the good first issue Good for newcomers label Sep 23, 2024
@YulikK YulikK self-assigned this Sep 23, 2024
@YulikK YulikK moved this from Backlog to In Progress in RS Site Sep 23, 2024
@YulikK YulikK moved this from In Progress to Peer review in RS Site Sep 23, 2024
@YulikK YulikK moved this from Peer review to In Progress in RS Site Sep 23, 2024
@YulikK YulikK moved this from In Progress to Peer review in RS Site Sep 24, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in RS Site Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants