Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSD: Widget StudyPath #566

Open
1 of 35 tasks
Quiddlee opened this issue Sep 27, 2024 · 0 comments
Open
1 of 35 tasks

FSD: Widget StudyPath #566

Quiddlee opened this issue Sep 27, 2024 · 0 comments

Comments

@Quiddlee
Copy link
Member

Quiddlee commented Sep 27, 2024

πŸ“ Describe the refactoring task

Part of the issue #347

πŸ“ Code location

src/widgets/study-path

βœ… Definition of Done (DoD):

*.scss

  1. Refactor scss as following
  • remove all parent selector & .card-content -> .card-content.
  • change all possible values to variables if such exists.
  • and everything in your opinion that needs to be refactored
  • replace all element selectors by tag with class selector img -> .image
  • move all the magic numbers to variables

study-path.tsx

  1. move localizedContent to dev-data
  2. replace interface with type
  3. move PathNames to types.ts
  4. move study-path component and all related pieces to study-path/ui/study-path

stages.tsx

  1. replace interface with type
  2. delete index.ts

stage-card.tsx

  1. replace p with Paragraph component
  2. replace div's with HTML5 tags
  3. delete index.ts

topics.tsx

  1. remove index.ts
  2. move localized content to dev-data
  3. replace interface with type
  4. remove unnecessary semicolon at the very bottom
  5. move topics folder outside of the stage-card folder directly to ui

step.tsx

  1. remove index.ts
  2. replace interface with type
  3. move step folder outside of the stage-card folder directly to ui

logo-icon.tsx

  1. remove index.ts
  2. replace interface with type
  3. move logo-icon folder outside of the stage-card folder directly to ui

links.tsx

  1. remove index.ts
  2. replace interface with type
  3. replace p with Paragraph component
  4. move links folder outside of the stage-card folder directly to ui

image.tsx

  1. remove index.ts
  2. replace interface with type
  3. move image folder outside of the stage-card folder directly to ui

types.ts

  1. rename stage-card.types.ts to type.ts
  2. replace all the interfaces with types
  3. move types.ts to stage-card root folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

3 participants