Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Subtitle to Support h2-h6 Tags #742

Open
SpaNb4 opened this issue Jan 20, 2025 · 1 comment
Open

Update Subtitle to Support h2-h6 Tags #742

SpaNb4 opened this issue Jan 20, 2025 · 1 comment
Labels
feature New feature or request

Comments

@SpaNb4
Copy link
Collaborator

SpaNb4 commented Jan 20, 2025

📝 Describe the feature

Subtitle component currently only renders an h3 tag.
The component should accept a new prop, for example, headingLevel (or similar, such as as), which is a string specifying the heading tag to be rendered. The component will default to h3 if this prop is not provided.

✅ Definition of Done (DoD):

  • New headingLevel Prop: The Subtitle component accepts a new prop named headingLevel (or as if preferable) as a string to specify the heading tag to be rendered. Valid values are h2, h3, h4, h5, and h6.
  • Default h3: If the headingLevel prop is not provided, the component should default to rendering an h3 tag.
  • Refactoring: All existing instances of the Subtitle component in the codebase have been reviewed and refactored to use the headingLevel prop where necessary and maintain all the existing styling.
  • Unit tests: New unit tests should be added to ensure that the new headingLevel prop behaves as expected with different heading levels.
  • No Styling Breaks: The current style of the subtitles doesn't break on any usage
@SpaNb4 SpaNb4 added the feature New feature or request label Jan 20, 2025
@SpaNb4 SpaNb4 added this to RS Site Jan 20, 2025
@ansivgit
Copy link
Collaborator

Also we would like variants for font-weight for it

@ansivgit ansivgit moved this to Backlog in RS Site Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants