Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move eth and engine client Dial to start method #17

Open
Tracked by #1802
tzdybal opened this issue Nov 28, 2024 · 0 comments
Open
Tracked by #1802

refactor: move eth and engine client Dial to start method #17

tzdybal opened this issue Nov 28, 2024 · 0 comments
Labels
code-hygiene execution-api

Comments

@tzdybal
Copy link
Member

tzdybal commented Nov 28, 2024

Currently all the dialing logic of EngineAPIExecutionClient is a part of constructor and the Start method is empty.

Consider moving ethclient.Dial and rpc.DialOptions calls to Start methods for better semantics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-hygiene execution-api
Projects
Rollkit
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tzdybal