You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running rollup to generate bundles & running jest --coverage-based unit tests on these bundles should output proper reports that carry valid paths to source files.
Actual Behavior
Running rollup & running tests with coverage generates coverage reports, however, file paths in the JSON reports contain paths that are one level above the root directory of the project. For instance, if the repo had been cloned to /home/user/Desktop/repo/, the paths to sources inside coverage-final.json files would have been /home/user/repo/ (Desktop omitted).
Additional Information
To reproduce, npm test could be run, however, since this is a complex pipeline, the following procedure will be easier to pinpoint the problems:
npm i
npm run build to run rollup
npm run test:unit to run jest with --coverage on test bundle produced by rollup in the previous step, with istanbul's instrumentation already present
check coverage/unit/coverage-final.json: it will contain the paths to sources being "one level too high" relative to the repo's root
The changes since previous commit, where everything has been working, include upgrading multiple packages and @rollup/plugin-typescript from ^11.1.6. However, even with all the changes present, when downgrading @rollup/plugin-typescript back to ^11.1.6, everything will work properly, effectively meaning that the issue most likely resides in the plugin.
The only logic that changes after upgrading to v12 is adding compilerOptions: { outDir: outDirOverride, }, to the plugin's options in rollup.config.js due to the new requirements (rollup plugin ts complaining about outDir not residing in the rollup file option location). Reverting the upgrade (see artus9033/chartjs-plugin-dragdata@d43a3cf) fixes the problem.
The text was updated successfully, but these errors were encountered:
@rollup/plugin-typescript
Expected Behavior
Running rollup to generate bundles & running
jest --coverage
-based unit tests on these bundles should output proper reports that carry valid paths to source files.Actual Behavior
Running rollup & running tests with coverage generates coverage reports, however, file paths in the JSON reports contain paths that are one level above the root directory of the project. For instance, if the repo had been cloned to
/home/user/Desktop/repo/
, the paths to sources insidecoverage-final.json
files would have been/home/user/repo/
(Desktop
omitted).Additional Information
To reproduce,
npm test
could be run, however, since this is a complex pipeline, the following procedure will be easier to pinpoint the problems:npm i
npm run build
to run rollupnpm run test:unit
to run jest with--coverage
on test bundle produced by rollup in the previous step, with istanbul's instrumentation already presentcoverage/unit/coverage-final.json
: it will contain the paths to sources being "one level too high" relative to the repo's rootThe changes since previous commit, where everything has been working, include upgrading multiple packages and
@rollup/plugin-typescript
from^11.1.6
. However, even with all the changes present, when downgrading@rollup/plugin-typescript
back to^11.1.6
, everything will work properly, effectively meaning that the issue most likely resides in the plugin.The only logic that changes after upgrading to v12 is adding
compilerOptions: { outDir: outDirOverride, },
to the plugin's options inrollup.config.js
due to the new requirements (rollup plugin ts complaining aboutoutDir
not residing in the rollupfile
option location). Reverting the upgrade (see artus9033/chartjs-plugin-dragdata@d43a3cf) fixes the problem.The text was updated successfully, but these errors were encountered: