Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema#[] should raise if more than one attribute was found #529

Closed
solnic opened this issue Apr 27, 2019 · 0 comments · Fixed by #543
Closed

Schema#[] should raise if more than one attribute was found #529

solnic opened this issue Apr 27, 2019 · 0 comments · Fixed by #543
Labels
bug
Milestone
6.0.0

Comments

@solnic
Copy link
Member

solnic commented Apr 27, 2019

If a schema contains more than one attribute with the same name, which can happen when you join schemas in sql, using Schema#[] will return the first matching attribute. This should be changed to raise an error when more than one attribute was found.

This is a bug fix but in a way it's also a breaking change, so this goes to 6.0.0.

Refs #524
@solnic solnic added the bug label Apr 27, 2019
@solnic solnic added this to the 6.0.0 milestone Apr 27, 2019
@solnic solnic mentioned this issue Apr 27, 2019
Open
waiting-for-dev added a commit that referenced this issue May 5, 2019
@waiting-for-dev
Make Schema#[] raise when attribute name is not unique
9b8ca5f 
Fixes #529
@waiting-for-dev waiting-for-dev mentioned this issue May 5, 2019
Merged
waiting-for-dev added a commit that referenced this issue Jun 25, 2020
@waiting-for-dev
Make Schema#[] raise when attribute name is not unique
699a9bb 
Fixes #529
solnic added a commit that referenced this issue Jun 25, 2020
@solnic
Merge pull request #543 from rom-rb/schema_raise_multiple_names
2e4c35b 
Make Schema#[] raise when attribute name is not unique

[changelog]

version: unreleased
changed: "`Schema#[]` and `Relation#[]` now raise an error if a given attribute is not unique (issue #529 fixed via #543) (@waiting-for-dev)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Make Schema#[] raise when attribute name is not unique rom-rb/rom
1 participant
@solnic