Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why do we must run it with https in localhost? #1

Open
HenriqueDerosa opened this issue Apr 28, 2020 · 5 comments
Open

why do we must run it with https in localhost? #1

HenriqueDerosa opened this issue Apr 28, 2020 · 5 comments

Comments

@HenriqueDerosa
Copy link

HenriqueDerosa commented Apr 28, 2020

Either using npm or yarn it doesnt work. Even if I set a different PORT.
Accessing it I get the default chrome error This page isn’t working

Edit: Then I realized this is caused by HTTPS=true in .env file. Is this really needed @pejulian ? Sounds like .env should not be in the repository, but just an example
Could we create a .env.example instead, and explain why https is needed with a short comment or in the readme file?

@HenriqueDerosa HenriqueDerosa changed the title Can't run the application npm start why do we must run it with https in localhost? Apr 28, 2020
@pejulian
Copy link
Contributor

Hello @HenriqueDerosa !

.env is just there mostly for demonstration purposes. We could, like you mentioned, change it to an example file with comments.

I didn't get to work much on this app apart from generating the scaffold. I was concentrating more on converting the core romcal library to TypeScript in the beginning of the year but was then pulled away for other matters.

The TypeScript based romcal library will allow us to install and import romcal in this front end and benefit from the typings its provides.

It would be awesome for you to contribute to this project! Historically, other contributors in this organization just use PR's or Project discussions to communicate with one another. We used to have a Gitter channel, but we shut it down because no one was really using it.

@HenriqueDerosa
Copy link
Author

Okay, that's nice.
@pejulian can you explain why do you need to use HTTPS in localhost ? Or it is not necessary? If so, I would recommend keeping its default value.

@HenriqueDerosa
Copy link
Author

Also @pejulian I would like to talk with some other way because I didn't get what is the idea of this frontend application. What and how would you show things in the calendar?

@pejulian
Copy link
Contributor

pejulian commented Apr 30, 2020 via email

@pejulian
Copy link
Contributor

pejulian commented May 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants