Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve admin email notification messages #17

Open
Bravo555 opened this issue Apr 26, 2018 · 0 comments
Open

Improve admin email notification messages #17

Bravo555 opened this issue Apr 26, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@Bravo555
Copy link
Member

Look

We could use some CSS and JS to make the email look nice. We can throw some fancy buttons to click for accepting/rejecting a quote instead of plain links.

Working method

Right now, to accept/reject a quote we use plain links that make the browser do GET request to accept|reject_with_token and provide token as path parameter. As using GET request to make changes on the server isn't accepted by the spec, we should have only one endpoint for accepting/rejecting the quotes and make the email system fit to them somehow. Fortunately, with a bit of javascript, we can make just use fetch() to use correct method (I suppose).

@Bravo555 Bravo555 added enhancement New feature or request invalid This doesn't seem right labels Apr 26, 2018
@Bravo555 Bravo555 self-assigned this Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant