Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for testing plot output, recommend testthat snapshot testing instead of vdiffr? #294

Closed
maelle opened this issue Dec 15, 2020 · 5 comments · Fixed by #764
Closed

for testing plot output, recommend testthat snapshot testing instead of vdiffr? #294

maelle opened this issue Dec 15, 2020 · 5 comments · Fixed by #764
Assignees
@maelle
Labels
content 📃

Comments

@maelle
Copy link
Member

maelle commented Dec 15, 2020

No description provided.

@maelle maelle added this to the 0.6.0 milestone Dec 15, 2020
@maelle maelle self-assigned this Dec 15, 2020
maelle added a commit that referenced this issue Jan 12, 2021
@maelle
mention more testing tools/guidance cf #208 #294
e2d475d
@maelle
Copy link
Member Author

maelle commented Jan 12, 2021

I added a mention of testthat snapshot tests. Not too sure what the recommendation, if any, should be.

r-lib/testthat#1265 (comment)

@maelle
Copy link
Member Author

maelle commented Jan 12, 2021

I'll remove this issue from the milestone, I'll update the guide when I learn more.

@maelle maelle removed this from the 0.6.0 milestone Jan 12, 2021
@maelle
Copy link
Member Author

maelle commented Jan 14, 2021

https://twitter.com/hadleywickham/status/1349704486806310914

@maelle
Copy link
Member Author

maelle commented Jun 18, 2021

https://vdiffr.r-lib.org/news/index.html#vdiffr-1-0-0-2021-06-08

@maelle maelle added this to the 0.8.0 milestone Nov 15, 2021
@maelle
Copy link
Member Author

maelle commented Jan 11, 2022

I'll wait a bit more r-lib/testthat#1553

@maelle maelle removed this from the 0.8.0 milestone Apr 28, 2022
@maelle maelle mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maelle maelle

Labels
content 📃
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix vdiffr phrasing ropensci/dev_guide
1 participant
@maelle