bottleneck for large networks

[KevCaz]

reprex: get_network_by_id(19)

I've been waiting for >15min, still not done, all data are in, it's a list of >15,000 elements, not that big.

The culprit is the do.call(rbind,) approach for large list of sf objects see r-spatial/sf#798. I'm working on a workaround, basically I'll delay the creation of sf object as much as possible.

[KevCaz]

Ok, in this case, actually we can avoid creating a sf object for nodes.
Not even sure it makes sense to have several sf in mgNetwork, better having a sf object for network and a dataframe for the nodes associated. What do you think @SteveViss ?

[KevCaz]

So even if we may not need it, new solution:

R> system.time(
+...   {gg = resp_to_spatial(dat)}
+... )

^C
Timing stopped at: 12.5 0 12.5 # did not want to wait
R> system.time(
+...   {gg = resp_to_spatial2(dat)}
+... )
   user  system elapsed 
  1.536   0.000   1.537