Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnr_resolve potential bug #248

Closed
sckott opened this issue Mar 3, 2014 · 2 comments
Closed

gnr_resolve potential bug #248

sckott opened this issue Mar 3, 2014 · 2 comments
Assignees
@sckott
Labels
bug
Milestone
v0.3

Comments

@sckott
Copy link
Contributor

sckott commented Mar 3, 2014

from an email...

Somehow setting resolve_once = TRUE in a call like gnr_resolve(names = ..., resolve_once = TRUE) does not give back just the first match as is supposed to happen. Looking into this.
@sckott sckott added the Bug label Mar 3, 2014
@sckott sckott added this to the v0.3 milestone Mar 3, 2014
@sckott
Copy link
Contributor Author

sckott commented Mar 3, 2014

Okay, so resolve_once does not mean to return only one result - just fix docs then GlobalNamesArchitecture/gni#32

@sckott
Copy link
Contributor Author

sckott commented Mar 10, 2014

Okay, so looks like there is a best_match_only argument I didn't know about GlobalNamesArchitecture/gni#32 (comment) - document and use. E..g, http://resolver.globalnames.org/name_resolvers.json?names=Plantago+major&best_match_only=true&data_source_ids=12

Also, there's a preferred_data_sources param I didn't know about

e.g., http://resolver.globalnames.org/name_resolvers.json?names=Plantago+major&best_match_only=true&preferred_data_sources=12%7C4

@sckott sckott self-assigned this Mar 10, 2014
@sckott sckott closed this as completed in d941cd9 May 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sckott sckott

Labels
bug
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@sckott