Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return tibble from cir_query() #289

Closed
andschar opened this issue Sep 15, 2020 · 1 comment
Closed

return tibble from cir_query() #289

andschar opened this issue Sep 15, 2020 · 1 comment
Assignees
@Aariq
Labels
consistent api Uniformity across functions and data sources

Comments

@andschar
Copy link
Contributor

cir_query() currently returns a list of vectors. Should we return a tibble instead? I know it's not a get_*() function, but it behaves very similar to them, since only identifiers are returned. Then again, it would be a breaking change.
@andschar andschar self-assigned this Sep 15, 2020
@andschar andschar added the consistent api Uniformity across functions and data sources label Sep 15, 2020
@Aariq
Copy link
Collaborator

Aariq commented Sep 15, 2020

related to #218

@andschar andschar mentioned this issue Sep 29, 2020
Open
@Aariq Aariq assigned Aariq and unassigned andschar Feb 15, 2022
@Aariq Aariq mentioned this issue Feb 15, 2022
Merged
4 tasks
@stitam stitam closed this as completed in 67d30b8 Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aariq Aariq

Labels
consistent api Uniformity across functions and data sources
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andschar @Aariq