Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default value to the dynamics #203

Open
roskuttan opened this issue Jun 1, 2023 · 2 comments
Open

Add a default value to the dynamics #203

roskuttan opened this issue Jun 1, 2023 · 2 comments

Comments

@roskuttan
Copy link

https://answers.ros.org/question/416011/strange-behavior-and-instability-of-six-axis-manipulator-in-ros-2-with-gazeboclassic-when-using-position-control/

The provided link addresses the actual issue. I would like to suggest adding a default value to the friction and damping parameters to minimize unnecessary errors and complications. As a newcomer to ROS, I apologize if this suggestion seems trivial or misguided. I am proposing this idea based on personal experience, as I encountered significant difficulty in identifying the root cause of the issue.

@danzimmerman
Copy link

Related to #73 and UniversalRobots/Universal_Robots_ROS2_Gazebo_Simulation#19

The Open Dynamics Engine fmax parameter was set to the joint's effort limit in gazebo_ros_control here.

It appears to default to zero in gazebo_ros2_control, and although it can be set via a URDF <dynamics> tag's friction attribute, that's not obvious or intutitive (Took me a while to find #73 to figure it out.)

@roskuttan
Copy link
Author

Hi @danzimmerman, I appreciate your explanation about the 'fmax' parameter and its implications in gazebo_ros2_control. Based on my experience, I suggest that we consider changing the default value of the 'fmax' parameter. This might help to prevent confusion and unintended errors, especially for newcomers in this field.

Alternatively, adding a clear warning in the documentation about the potential issues when the dynamics tags are not properly set could be beneficial. This could highlight the importance of setting these tags and the potential problems that might occur if they are omitted.

I believe these changes could significantly improve user experience and make it easier for beginners to understand and use gazebo_ros2_control effectively. Thanks again for your insightful explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants