Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shared generator code to the base class or a core helper #578

Open
tfoote opened this issue Mar 10, 2020 · 1 comment
Open

Move shared generator code to the base class or a core helper #578

tfoote opened this issue Mar 10, 2020 · 1 comment
Labels
enhancement help wanted

Comments

@tfoote
Copy link
Member

tfoote commented Mar 10, 2020

In debugging #577 @sloretz and I found many functions that are shared between the two generators that are sometimes even identical and do not need to be duplicated.

In particular: bloom/generators/debian/generator.py bloom/generators/rpm/generator.py
@cottsay
Copy link
Member

cottsay commented Mar 10, 2020

I think this was one of the goals of #539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tfoote @cottsay