Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage breaks if you specify a different compiler #956

Open
flynneva opened this issue Feb 9, 2025 · 2 comments
Open

Code coverage breaks if you specify a different compiler #956

flynneva opened this issue Feb 9, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@flynneva
Copy link
Contributor

flynneva commented Feb 9, 2025

Description

It looks like the CMAKE args are not forwarded to the coverage commands:

Image

Expected Behavior

Code coverage mixin still works if specifying a different compiler via --cmake-args

Actual Behavior

Code coverage mixin fails, since I think it uses a different compiler (whatever the system default is) to generate code coverage.

See this job for an example.

To Reproduce

  1. See this commit where I disabled the code-coverage mixin from this action on how to reproduce

System (please complete the following information)

  • OS: Any
  • ROS 2 Distro: Any
@flynneva flynneva added the bug Something isn't working label Feb 9, 2025
@flynneva
Copy link
Contributor Author

flynneva commented Feb 9, 2025

fyi @christophebedard

@christophebedard
Copy link
Member

christophebedard commented Feb 9, 2025

It might work if you provide the CMake args through the colcon-defaults input instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants