From 7b3552753d878ffdb9d48c6bd7f9ab652dbb58df Mon Sep 17 00:00:00 2001
From: Tully Foote <tfoote@osrfoundation.org>
Date: Thu, 17 Jun 2021 10:09:47 -0700
Subject: [PATCH] Add pip specific content contribution rosdep rules for Gentoo
 (#29909)

* Add pip specific content for Gentoo
Fixes: #29908

Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
---
 .github/pull_request_template.md | 3 ++-
 CONTRIBUTING.md                  | 6 ++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index 5c2663a133232..ea640aefded3e 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -25,7 +25,8 @@ Distro packaging links:
 
 ## Links to Distribution Packages
 
-<!-- Replace the REQUIRED areas and state not available for IF AVAILABLE -->
+<!-- Replace the REQUIRED areas with the URL to the package.  For IF AVAILABLE areas, either put in the URL to the package or state 'not available'.
+More info at https://github.com/ros/rosdistro/blob/master/CONTRIBUTING.md#guidelines-for-rosdep-rules -->
 
 - Debian: https://packages.debian.org/
   - REQUIRED
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index e7cef9d26855e..855844a2cea9b 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -136,6 +136,9 @@ TODO
 If the ebuild you are referencing is not in either of those locations, please
 file a PR into ROS-Overlay to add it and any needed dependencies to the tree.
 
+Note that `pip` cannot be used to install system packages on Gentoo.
+If the package is not present in the Gentoo package repository, please create an issue on the https://github.com/ros/ros-overlay repository so that it may be created at a later date, omit the key from the new rosdep rule, and link the created issue in the PR which is adding the rule. [Here's a simple example](https://github.com/ros/ros-overlay/issues/1019).
+
 #### Arch Linux
 
 Packages must be in the official Archlinux core, extra, or community repositories at the time they are contributed.
@@ -228,6 +231,9 @@ Some existing rules do not have `python-` or `python3-` prefixes, but this is no
 If the package ever becomes available in Debian or Ubuntu, the `python3-` prefix ensures that the `pip` key is next to it alphabetically.
 The `-pip` key should be removed when the package becomes available on all platforms, and all existing users of the `-pip` key should migrate to the new key.
 
+As a reminder `pip` rules should not be used on Gentoo.
+See above for the Gentoo specific guidelines.
+
 How to submit pull requests
 ---------------------------