Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$(find) no longer resolved after other args #338

Closed
adamheins opened this issue Feb 29, 2024 · 2 comments · Fixed by #339
Closed

$(find) no longer resolved after other args #338

adamheins opened this issue Feb 29, 2024 · 2 comments · Fixed by #339

Comments

@adamheins
Copy link
Contributor

On the noetic-devel branch, resolving substitution arguments was outsourced to roslaunch. This resolves $(find) after other arguments like $(arg) (see here), which means I do things like pass $(find) into an argument. For example:

<xacro:arg name="robotfile" default="default.urdf.xacro"/>
<xacro:include filename="$(arg robotfile)"/>

and then I could pass in something like robotfile:=$(find mypkg)/urdf/robot.urdf.xacro, and expect the included filename to ultimately be resolved properly through the $(arg) and $(find).

On the ros2 branch, this logic has been changed so that the above no longer works for me. I'm wondering if this change was intended, or if I'm just doing something wrong here.

@rhaschke
Copy link
Contributor

rhaschke commented Mar 1, 2024

Fixed via #339. Do you need a release? Into which ROS2 distros?

@adamheins
Copy link
Contributor Author

Thanks, that does it! I don't actually need a release; I came across this while working on xacrodoc, which is a small tool that modifies xacro to (1) have more support for programmatically compiling files, and (2) makes the package-lookup mechanism fully functional even without ROS.

adamheins added a commit to adamheins/xacrodoc that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants