Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose types for tracing tools #153

Merged
merged 7 commits into from
Feb 24, 2025
Merged

Expose types for tracing tools #153

merged 7 commits into from
Feb 24, 2025

Conversation

InvincibleRMC
Copy link
Contributor

No description provided.

@InvincibleRMC
Create py.typed
78b5058 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Create py.typed
a65f4e4 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Create py.typed
7f9c887 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Create py.typed
e8b5ee1 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Create py.typed
915c771 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Create py.typed
a159e42 
Signed-off-by: Michael Carlstrom <[email protected]>
@christophebedard christophebedard self-requested a review February 24, 2025 04:32
@christophebedard
Copy link
Member

The mypy GitHub actions failures are unrelated; they started happening in the nightly (GitHub actions) jobs a few days ago. The Rpr job looks good, so this is fine.

christophebedard
christophebedard requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See question about ros2trace/py.typed

@InvincibleRMC
remove incorrect py.typed
ee94c67 
Signed-off-by: Michael Carlstrom <[email protected]>
@InvincibleRMC
Copy link
Contributor Author

InvincibleRMC commented Feb 24, 2025 •
edited
Loading

Good catch. Not sure how I missed that.

@christophebedard
Copy link
Member

@ros-pull-request-builder retest this please

@christophebedard
Copy link
Member

christophebedard commented Feb 24, 2025 •
edited
Loading

Pulls: #153
Gist: https://gist.githubusercontent.com/christophebedard/f9f5db92ef52491625c626efafba4185/raw/347056a26f1f7cc1ea41220053a078d554c114ac/ros2.repos
BUILD args: --packages-above-and-dependencies ros2trace tracetools_launch tracetools_read tracetools_test tracetools_trace
TEST args: --packages-above ros2trace tracetools_launch tracetools_read tracetools_test tracetools_trace
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15242

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

christophebedard
christophebedard approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@christophebedard christophebedard merged commit 4422a68 into ros2:rolling Feb 24, 2025
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InvincibleRMC @christophebedard