-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport timeout options on humble #855
Comments
you can see https://docs.ros.org/en/rolling/How-To-Guides/Package-maintainer-guide.html#backporting-to-released-distributions as guideline. AFAIK, it also depends on the behavior change that could affect the application, tools and so on. adding command line options can be considered as behavior change. but on this one, i do not see any of that, so it would be probably okay to go? that is not i am 100% sure, so lets keep this open for more feedback. Related PRs, CC: @ros2/team @clalancette @wjwwood @audrow |
Thank you for the consideration! I would also like these backported:
They also looked straightforward and not breaking anything. I have not checked all the options, though. |
The general policy is to only backport as things are requested, and as feasible. Because of our strong API and ABI guarantees in the core, backports are often non-trivial (though they tend to be easier with Python). For the ones you've requested:
@tokoro10g if you'd like to backport these (keeping the current API), we'd be happy to review them |
Feature request
Feature description
ros2 topic echo --time-out
on humbleImplementation considerations
Is there any policy for backporting? My opinion is that these basic tools should have the same interface across the distributions until it reaches the EOL. What do you say?
The text was updated successfully, but these errors were encountered: