Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redlionfish on Mac M1 (arm64) #13

Open
haesleinhuepf opened this issue Sep 30, 2022 · 8 comments
Open

Redlionfish on Mac M1 (arm64) #13

haesleinhuepf opened this issue Sep 30, 2022 · 8 comments

Comments

@haesleinhuepf
Copy link

Hi Luis @perdigao1 , hi all,

I just got a report from a collaborator that our napari-plugin distribution devbio-napari cannot be installed on Mac M1 because of an issue with RedLionFish. devbio-napari depends on redlionfish. The reported error was (I would provide more details if I could):

Encountered problems while solving:
  - nothing provides redlionfish needed by devbio-napari-0.1.5-pyhd8ed1ab_0

I know by chance that pyopencl works on Mac M1 and thus, was wondering why conda can't find a redlionfish that's compatible with this system. Can you give further insights?

No hurry btw. I removed redlionfish from the distribution temporarily so that the installation becomes functional again. I would be very happy to put it back in though!

Thanks!

Best,
Robert

@perdigao1
Copy link
Contributor

perdigao1 commented Sep 30, 2022

Hi Robert,

Thank you for reporting that problem. I will have a look into it. I am currently fixing other issues with the code.

I have updated recently the RedLionfish in PyPI (PyOpenCL can now be installed using pip with the precompiled libraries) but not in conda but there should be a working version there. I will check github actions if any error occurred in Mac env.

You do say that it is arm64 (not intel), not sure if conda-forge compiles for that

Cheers
Luis

@haesleinhuepf
Copy link
Author

You do say that it is arm64 (not intel), not sure if conda-forge compiles for that

That might be the problem then. Maybe @jaimergp can assist us in making redlionfish deploy on Mac arm64? 🙃

@jaimergp
Copy link

The migration PR is there conda-forge/redlionfish-feedstock#5

It needs to be reviewed and merged by @perdigao1. I have ordered the bot to re-run it to make sure it's current. Once it lands again, you can review it!

There's also a pending version update (to be merged only after the osx-arm64 support PR).

@haesleinhuepf
Copy link
Author

Amazing, thanks for the lightspeed response @jaimergp ! 🤩

@perdigao1
Copy link
Contributor

perdigao1 commented Sep 30, 2022

OK. I updated the package to version v0.8 and went through a maze of pushes, pulls and merges. I think I managed to get it right now., and I hope it is working. Thank you @jaimergp for fixing and to @haesleinhuepf for highlighting these issues.

Let me know if there are any problems.

@jaimergp
Copy link

jaimergp commented Oct 1, 2022

Issued an automated fix for some permissions issue with the macOS scripts. conda-forge/redlionfish-feedstock#10

@jaimergp
Copy link

jaimergp commented Oct 1, 2022

Btw, is RedLionFish using any compiled extensions? I think it qualifies for noarch, given that it seems to be pure Python. That would reduce the amount of builds to one or two. I do see you have conditional requirements (ocl-icd-system on Linux only), but that can be worked around with noarch_platforms as we did for devbio-napari. I can set this up for you if you are interested!

@perdigao1
Copy link
Contributor

Yes. RedLionFish is python only. I don't know how to setup. Please feel free to setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants