SubmoduleAwareBuilder incorrectly works with "deep" submodules and when len(submodules) > 2 #414
Labels
bug
Something is clearly a bug
effort/medium
Can be done in 1-2 days
gain/medium
Affects multiple users
SubmoduleAwareBuilder incorrectly works with "deep" submodules and when len(submodules) > 2
Lets consider https://github.com/microsoft/onnxruntime.
Look, at submodule lists: modules can include backslashes in their names…
and definitely crashed
tito/src/tito/builder/submodule_aware_builder.py
Line 76 in 71c2712
because parent subdirectory for output tar does not exists.
Also, here exists a try to concatenate tar archives for submodules
tito/src/tito/builder/submodule_aware_builder.py
Line 141 in 71c2712
But actually, it does not work, if len(submodules)>2.
See «Only the first archive (the one after the -f option) gets its EOF marker removed. If you try to concatenate more than 2 archives the last archive(s) will be "hidden" behind file-end-markers.»
So resulting tar need to be «retared/fixed» to not loose additional archives/submodules.
And if we "retar" and "fix tar", it will be crashing on
tito/src/tito/tar.py
Line 292 in 7177422
because "tar that maded by tar" allows "devmajor" props like empty string.
The text was updated successfully, but these errors were encountered: