Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch files appear to not be copied into SOURCES #447

Closed
yorickpeterse opened this issue Feb 28, 2023 · 1 comment
Closed

Patch files appear to not be copied into SOURCES #447

yorickpeterse opened this issue Feb 28, 2023 · 1 comment

Comments

@yorickpeterse
Copy link

I'm building lua-language-server using tito (mostly because it seems rpkg is deprecated, and doing things using spectool and rpmbuild directly is a bit of a pain). Because of this bug the build fails on Fedora 38/Rawhide, requiring a patch.

Unfortunately it seems Tito doesn't copy patch files into SOURCES unless they are also listed as a source. So if you do something like this it won't work:

...
Source0: https://...
Patch0:  kittens.patch
...

%prep
%patch0 -p0

However, something like this does work:

...
Source0: https://...
Source1: kittens.patch
Patch0:  kittens.patch
...

%prep
%patch0 -p0

This is just using the default tito.props file:

[buildconfig]
builder = tito.builder.Builder
tagger = tito.tagger.VersionTagger
changelog_do_not_remove_cherrypick = 0
changelog_format = %s (%ae)

A real example of where I had to apply this is this spec file.

@yorickpeterse
Copy link
Author

It seems @FrostyX beat me to it by a few minutes by creating #446, so I'll close this issue in favour of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant