overrideWithValue only makes test harder than before

[lcdsmao]

Hi, I am trying to update to the latest 1.0-dev, and have some questions about removing overrideWithProvider.
When overrideWithProvider exits, we can always write how to create the container in the setUp.
Now with overrideWithValue only, our test code becomes more verbose than before in these patterns:

Pattern 1: Get provider value lazily

Before:

void main() {
  late FakeSharedPreferences fakeSharedPreferences;
  late ProviderContainer container;

  setUp(() {
    fakeSharedPreferences = FakeSharedPreferences();

    container = ProviderContainer(
      overrides: [
        sharedPreferencesDataSourceProvider.overrideWithValue(
          fakeSharedPreferences,
        ),
      ],
    );
  });

  test('case 1', () {
    // setup data before read usecase
    fakeSharedPreferences.map = {
      'key': false,
    };

    final useCase = container.read(myUseCaseProvider);
    // test
  }

  test('case 2', () {
    fakeSharedPreferences.map = {
      'key': true,
    };

    final useCase = container.read(myUseCaseProvider);
    // test
  }
}

After:

void main() {
  late FakeSharedPreferences fakeSharedPreferences;
  ProviderContainer createContainer() {
    return ProviderContainer(
      overrides: [
        sharedPreferencesDataSourceProvider.overrideWithProvider(
          Provider<SharedPreferences>(
            (_) => fakeSharedPreferences,
          ),
        ),
      ],
    );
  }

  setUp(() {
    fakeSharedPreferences = FakeSharedPreferences();
  });

  test('case 1', () {
    fakeSharedPreferences.map = {
      'key': false,
    };
    
    final container = createContainer();
    final useCase = container.read(myUseCaseProvider);
    // test
  }

  test('case 2', () {
    fakeSharedPreferences.map = {
      'key': true,
    };

    final container = createContainer();
    final useCase = container.read(myUseCaseProvider);
    // test
  }
}

Pattern 2: Override all family provider

Before:

void main() {
  late FakeObj fakeObj;
  late ProviderContainer container;

  setUp(() {
    fakeObj = FakeObj();

    container = ProviderContainer(
      overrides: [
        sharedPreferencesDataSourceProvider.overrideWithProvider(
            (_) => Provider(
              (ref) => fakeObj,
            ),
        ),
      ],
    );
  });
}

After:

void main() {
  late FakeObj fakeObj;
  ProviderContainer container(Param param) {
    return ProviderContainer(
      overrides: [
        sharedPreferencesDataSourceProvider(param).overrideWithValue(
            fakeObj,
        ),
      ],    
     );
  }

  setUp(() {
    fakeObj = FakeObj();
  });
}

[rrousselGit]

To begin with, I'd advise against setUp for creating ProviderContainer & override. That should be part of the test, not a setUp function.

Your snippets are a bit broad. Could you explain in depth what the problem is and why both use-cases are desirable?

[lcdsmao]

Thanks, you are right. 👍

[lcdsmao]

I will create a new discussion about provider family override