Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test lints related to ProviderScopes with tester.pumpWidget #2355

Closed
rrousselGit opened this issue Mar 20, 2023 · 5 comments
Closed

Test lints related to ProviderScopes with tester.pumpWidget #2355

rrousselGit opened this issue Mar 20, 2023 · 5 comments
Assignees
@rrousselGit
Labels
enhancement New feature or request linter
Milestone
Riverpod 3.0

Comments

@rrousselGit
Copy link
Owner

rrousselGit commented Mar 20, 2023 •
edited
Loading

  • missing ProviderScope
  • root overrides
  • scoping (when done)
@rrousselGit rrousselGit added enhancement New feature or request linter labels Mar 20, 2023
@rrousselGit rrousselGit self-assigned this May 10, 2023
@rrousselGit rrousselGit changed the title Test root scope overrides with tester.pumpWidget Test lints related to ProviderScopes with tester.pumpWidget Jun 29, 2023
@rrousselGit rrousselGit added this to the Post 3.0 release milestone Oct 15, 2023
@rrousselGit rrousselGit mentioned this issue Oct 28, 2023
Closed
@lockieRichter
Copy link
Contributor

@rrousselGit you looking for contributions on this one?

@rrousselGit
Copy link
Owner Author

Sure, if you will like fixing it, go ahead.

We'd likely want to update the lint to consider "pumpWidget" the same as "runApp"

@lockieRichter
Copy link
Contributor

Opened #3056 in Draft status right now, I've asked on Discord, but wondering how I run the tests locally for the riverpod_lint package?

@rrousselGit
Copy link
Owner Author

rrousselGit commented Oct 29, 2023 •
edited
Loading

dart test in packages/riverpod_lint_flutter_test

@lockieRichter
Copy link
Contributor

ahh good one, I was using flutter test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrousselGit rrousselGit

Labels
enhancement New feature or request linter
Projects
None yet
Milestone
Riverpod 3.0
Development

No branches or pull requests
2 participants
@rrousselGit @lockieRichter