Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not detect modules info under Windows 64-bit #7

Open
misha-ridge opened this issue Oct 17, 2018 · 2 comments · May be fixed by #17
Open

Does not detect modules info under Windows 64-bit #7

misha-ridge opened this issue Oct 17, 2018 · 2 comments · May be fixed by #17

Comments

@misha-ridge
Copy link

goversion fails to find modules table under Windows 64-bit: goversion searches it in .text while it is in .rdata.
@misha-ridge
Copy link
Author

An example file where it fails: deadcode.zip

@misha-ridge misha-ridge mentioned this issue Oct 17, 2018
Closed
@makon
Copy link

makon commented Aug 14, 2019

Unfortunately your fix did not work for me, not sure why. The list was still empty in windows.

But the PR #9 did the trick, even with your deadcode.exe.

FiloSottile added a commit to FiloSottile/goversion that referenced this issue Dec 15, 2020
@FiloSottile
goversion: rewrite on top of cmd/go/internal/version
967a33b 
Imported the cmd/go/internal/version implementation at
c32140fa94cfc51a2152855825f57e27ae3ba133, and restored Symbols and
TextRange to implement the gccgo and crypto checks.

It looks like the amd64 matching had broken, but it should be more
stable to just track what we do upstream with minimal modifications, so
I replaced the core mechanism rather than fixing the matcher.

Fixes rsc#14
Fixes rsc#12
Fixes rsc#11
Fixes rsc#7
Closes rsc#13
Closes rsc#9
@FiloSottile FiloSottile linked a pull request Dec 15, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@makon @misha-ridge