Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a CFDTicker class and member variable defaultProperty in Ticker #31

Open
aries1998 opened this issue Sep 23, 2016 · 4 comments
Open

Comments

@aries1998
Copy link

1 add cfdTick : cfd is quite popular is ib today
2 add member variable defaultProperty in Ticker : will be more convenient cause some ticker type like cfd can only require bid/ask data , no trades data.

i have made this change of my local pc. Becasue Ticker and ShowProperty are in different package , add dependency of differnt package will make it ugly so i didn't make a pull request. Hope you can tweak it nicely.

And thanks for your great work .

@rterp
Copy link
Owner

rterp commented Sep 28, 2016

Thanks @aries1998, I understand the new tick type, but what is the new defaultProperty in the Ticker class? Could you attach a code snippet, and I can get it integrated into the library?

thanks,
-Rob

@aries1998
Copy link
Author

defaultProperty is IHistoricalDataProvider.ShowProperty.xxxxx
normally we use IHistoricalDataProvider.ShowProperty.TRADES, but for forex , cfd or maybe other types of instruments , we can only use IHistoricalDataProvider.ShowProperty.BID for the data

@rterp
Copy link
Owner

rterp commented Oct 3, 2016

ah, ok. I'll try to get this integrated this week.

@rterp
Copy link
Owner

rterp commented Oct 7, 2016

Initial support for a CFDTicker has been added. I've written unit tests, but have not actually tested yet with IB's API in the demo or paper trade account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants