Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONNX support #1

Closed
wtesler opened this issue Dec 6, 2024 · 4 comments
Closed

ONNX support #1

wtesler opened this issue Dec 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@wtesler
Copy link

wtesler commented Dec 6, 2024

Is there a way to run the Birefnet ONNX model with this node?

@rubi-du
Copy link
Owner

rubi-du commented Dec 9, 2024

Is there a way to run the Birefnet ONNX model with this node?

@wtesler Hi,This is a good point of view,I will add this feature as soon as possible

@rubi-du
Copy link
Owner

rubi-du commented Dec 10, 2024

@wtesler We have added node that support onnx,you can try it now. the doc: https://github.com/rubi-du/ComfyUI-BiRefNet-Super?tab=readme-ov-file#birefnet_onnx

@wtesler
Copy link
Author

wtesler commented Dec 10, 2024

@rubi-du Thanks! I have tried it out. I was wondering if an MPS option could work for it too just like the other node? I know the official Birefnet repo has ONNX models that do support MPS.

Also, it seems with latest change, there are new requirements on onnxruntime and pooch which you might want to outline somewhere perhaps in the requirements.txt

@rubi-du
Copy link
Owner

rubi-du commented Dec 11, 2024

@wtesler
Thank you very much. We have added the relevant dependencies in the requirement.
But we searched for ONNX related documents and did not find any information about support MPS provider.
this is the related issue: microsoft/onnxruntime#21271
If you have relevant information, you can provide it to us and we will do our best to solve this problem

@rubi-du rubi-du added the enhancement New feature or request label Dec 13, 2024
@wtesler wtesler closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants