From 8c683bce7516f3e372b4c63acfaf77ce56507e41 Mon Sep 17 00:00:00 2001
From: Connor Dudas <dudasc@mail.gvsu.edu>
Date: Thu, 10 Oct 2024 16:50:16 -0600
Subject: [PATCH] [FIX #1376] Add new Rails/Env cop

---
 changelog/new_env_cop.md           |  1 +
 config/default.yml                 |  5 +++
 lib/rubocop/cop/rails/env.rb       | 57 ++++++++++++++++++++++++++++++
 lib/rubocop/cop/rails_cops.rb      |  1 +
 spec/rubocop/cop/rails/env_spec.rb | 37 +++++++++++++++++++
 5 files changed, 101 insertions(+)
 create mode 100644 changelog/new_env_cop.md
 create mode 100644 lib/rubocop/cop/rails/env.rb
 create mode 100644 spec/rubocop/cop/rails/env_spec.rb

diff --git a/changelog/new_env_cop.md b/changelog/new_env_cop.md
new file mode 100644
index 0000000000..c97bc19915
--- /dev/null
+++ b/changelog/new_env_cop.md
@@ -0,0 +1 @@
+* [#1376](https://github.com/rubocop/rubocop-rails/issues/1376): Add new `Rails/Env` cop. ([@cdudas17][])
diff --git a/config/default.yml b/config/default.yml
index 0e7d183460..326c3cada1 100644
--- a/config/default.yml
+++ b/config/default.yml
@@ -441,6 +441,11 @@ Rails/EnumUniqueness:
   Include:
     - app/models/**/*.rb
 
+Rails/Env:
+  Description: 'Use Feature Flags or config instead of `Rails.env`.'
+  Enabled: false
+  VersionAdded: '<<next>>'
+
 Rails/EnvLocal:
   Description: 'Use `Rails.env.local?` instead of `Rails.env.development? || Rails.env.test?`.'
   Enabled: pending
diff --git a/lib/rubocop/cop/rails/env.rb b/lib/rubocop/cop/rails/env.rb
new file mode 100644
index 0000000000..bfc4ebe2b7
--- /dev/null
+++ b/lib/rubocop/cop/rails/env.rb
@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Rails
+      # Checks for usage of `Rails.env` which can be replaced with Feature Flags
+      #
+      # @example
+      #
+      #   # bad
+      #   Rails.env.production? || Rails.env.local?
+      #
+      #   # good
+      #   if FeatureFlag.enabled?(:new_feature)
+      #     # new feature code
+      #   end
+      #
+      class Env < Base
+        MSG = 'Use Feature Flags or config instead of `Rails.env`.'
+        RESTRICT_ON_SEND = %i[env].freeze
+        # This allow list is derived from:
+        # (Rails.env.methods - Object.instance_methods).select { |m| m.to_s.end_with?('?') }
+        # and then removing the environment specific methods like development?, test?, production?, local?
+        ALLOWED_LIST = Set.new(
+          %i[
+            unicode_normalized?
+            exclude?
+            empty?
+            acts_like_string?
+            include?
+            is_utf8?
+            casecmp?
+            match?
+            starts_with?
+            ends_with?
+            start_with?
+            end_with?
+            valid_encoding?
+            ascii_only?
+            between?
+          ]
+        ).freeze
+
+        def on_send(node)
+          return unless node.receiver&.const_name == 'Rails'
+
+          parent = node.parent
+          return unless parent&.predicate_method?
+
+          return if ALLOWED_LIST.include?(parent.method_name)
+
+          add_offense(parent)
+        end
+      end
+    end
+  end
+end
diff --git a/lib/rubocop/cop/rails_cops.rb b/lib/rubocop/cop/rails_cops.rb
index b7eddc4fe4..c966c86f13 100644
--- a/lib/rubocop/cop/rails_cops.rb
+++ b/lib/rubocop/cop/rails_cops.rb
@@ -48,6 +48,7 @@
 require_relative 'rails/enum_hash'
 require_relative 'rails/enum_syntax'
 require_relative 'rails/enum_uniqueness'
+require_relative 'rails/env'
 require_relative 'rails/env_local'
 require_relative 'rails/environment_comparison'
 require_relative 'rails/environment_variable_access'
diff --git a/spec/rubocop/cop/rails/env_spec.rb b/spec/rubocop/cop/rails/env_spec.rb
new file mode 100644
index 0000000000..69628ea9cb
--- /dev/null
+++ b/spec/rubocop/cop/rails/env_spec.rb
@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::Rails::Env, :config do
+  it 'registers an offense for `Rails.env.development? || Rails.env.test?`' do
+    expect_offense(<<~RUBY)
+      Rails.env.development? || Rails.env.test?
+                                ^^^^^^^^^^^^^^^ Use Feature Flags or config instead of `Rails.env`.
+      ^^^^^^^^^^^^^^^^^^^^^^ Use Feature Flags or config instead of `Rails.env`.
+    RUBY
+  end
+
+  it 'registers an offense for `Rails.env.production?`' do
+    expect_offense(<<~RUBY)
+      Rails.env.production?
+      ^^^^^^^^^^^^^^^^^^^^^ Use Feature Flags or config instead of `Rails.env`.
+    RUBY
+  end
+
+  it 'does not register an offense for `Rails.env`' do
+    expect_no_offenses(<<~RUBY)
+      Rails.env
+    RUBY
+  end
+
+  it 'does not register an offense for valid Rails.env methods' do
+    expect_no_offenses(<<~RUBY)
+      Rails.env.capitalize
+      Rails.env.empty?
+    RUBY
+  end
+
+  it 'does not register an offense for unrelated config' do
+    expect_no_offenses(<<~RUBY)
+      Rails.environment
+    RUBY
+  end
+end