-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword arguments to async #1040
Comments
There is nothing wrong to get And I can not reproduce |
I have same error in Ruby 3.0.3, concurrent-ruby 1.3.4. class Echo1
include Singleton
include Concurrent::Async
def echo(msg)
puts msg
end
end
def _a(echoer)
p echoer.class
echoer.async.echo('A')
end and
(works fine) class Echo2
include Singleton
include Concurrent::Async
def echo(msg:)
puts msg
end
end
def _b0(echoer)
p echoer.class
echoer.echo(msg: 'B0')
end
def _b1(echoer)
p echoer.class
echoer.async.echo(msg: 'B1')
end
(works fine) and
where |
Could you start a PR to fix and add specs for this? |
@eregon I should have some time near the end of the weak if no else picks this up |
ok, I hope it's not a big deal. |
Feature request
Add support for keyword arguments when using async
From the docs
but if i modify it to use named arguments like so it doesn't work
I appreciate any future feedback from the maintainers on this 🙏
System information
The text was updated successfully, but these errors were encountered: