Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for delete_all #565

Closed
mohammednasser-32 opened this issue Sep 15, 2024 · 3 comments · Fixed by #566
Closed

Support for delete_all #565

mohammednasser-32 opened this issue Sep 15, 2024 · 3 comments · Fixed by #566

Comments

@mohammednasser-32
Copy link
Contributor

mohammednasser-32 commented Sep 15, 2024 •
edited
Loading

I was wondering if it is intentional that the gem does not support delete_all action, It is the reason behind this bug since has_many_through uses delete_all to delete the related associations.

I was going to work on a PR to add it but I thought it would be better to double check first

Thank you
@mohammednasser-32 mohammednasser-32 changed the title Support for delete_all and destroy_all Support for delete_all Sep 15, 2024
@mohammednasser-32
Copy link
Contributor Author

@mathieujobin Hello 👋 can you please let me know if I can proceed with this? Thanks

@mathieujobin
Copy link
Collaborator

Yes please proceed.

If you could wrap your changes with a setting and make sure to cover up the feature with tests, that would be most appreciated 👍

Thanks

@mohammednasser-32 mohammednasser-32 mentioned this issue Sep 24, 2024
Merged
@mohammednasser-32
Copy link
Contributor Author

@mathieujobin Done 🙏 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle #delete_all mohammednasser-32/paranoia
2 participants
@mathieujobin @mohammednasser-32