diff --git a/src/main/java/pl/touk/sputnik/engine/ProcessorBuilder.java b/src/main/java/pl/touk/sputnik/engine/ProcessorBuilder.java index e00f38d5..9c4254f5 100644 --- a/src/main/java/pl/touk/sputnik/engine/ProcessorBuilder.java +++ b/src/main/java/pl/touk/sputnik/engine/ProcessorBuilder.java @@ -16,12 +16,12 @@ public class ProcessorBuilder { public static List buildProcessors(Configuration configuration) { List processors = new ArrayList<>(); - ServiceLoader theLoader = ServiceLoader.load(ReviewProcessorFactory.class); - Iterator theIterator = theLoader.iterator(); - while (theIterator.hasNext()) { - ReviewProcessorFactory theFactory = theIterator.next(); - if (theFactory.isEnabled(configuration)) { - processors.add(theFactory.create(configuration)); + ServiceLoader loader = ServiceLoader.load(ReviewProcessorFactory.class); + Iterator iterator = loader.iterator(); + while (iterator.hasNext()) { + ReviewProcessorFactory factory = iterator.next(); + if (factory.isEnabled(configuration)) { + processors.add(factory.create(configuration)); } } return processors; diff --git a/src/main/java/pl/touk/sputnik/processor/ReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/ReviewProcessorFactory.java index 80c62deb..47003314 100644 --- a/src/main/java/pl/touk/sputnik/processor/ReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/ReviewProcessorFactory.java @@ -5,7 +5,7 @@ public interface ReviewProcessorFactory { - boolean isEnabled(Configuration aConfiguration); + boolean isEnabled(Configuration configuration); - T create(Configuration aConfiguration); + T create(Configuration configuration); } diff --git a/src/main/java/pl/touk/sputnik/processor/checkstyle/CheckstyleReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/checkstyle/CheckstyleReviewProcessorFactory.java index a1a2d037..d965c8bf 100644 --- a/src/main/java/pl/touk/sputnik/processor/checkstyle/CheckstyleReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/checkstyle/CheckstyleReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class CheckstyleReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.CHECKSTYLE_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.CHECKSTYLE_ENABLED)); } @Override - public CheckstyleProcessor create(Configuration aConfiguration) { - return new CheckstyleProcessor(aConfiguration); + public CheckstyleProcessor create(Configuration configuration) { + return new CheckstyleProcessor(configuration); } } diff --git a/src/main/java/pl/touk/sputnik/processor/codenarc/NodeCardReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/codenarc/NodeCardReviewProcessorFactory.java index 7ebb70d0..6eb78561 100644 --- a/src/main/java/pl/touk/sputnik/processor/codenarc/NodeCardReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/codenarc/NodeCardReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class NodeCardReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.CODE_NARC_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.CODE_NARC_ENABLED)); } @Override - public CodeNarcProcessor create(Configuration aConfiguration) { - return new CodeNarcProcessor(aConfiguration); + public CodeNarcProcessor create(Configuration configuration) { + return new CodeNarcProcessor(configuration); } } diff --git a/src/main/java/pl/touk/sputnik/processor/findbugs/FindbugsReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/findbugs/FindbugsReviewProcessorFactory.java index 3957514a..bba9e95c 100644 --- a/src/main/java/pl/touk/sputnik/processor/findbugs/FindbugsReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/findbugs/FindbugsReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class FindbugsReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.FINDBUGS_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.FINDBUGS_ENABLED)); } @Override - public FindBugsProcessor create(Configuration aConfiguration) { - return new FindBugsProcessor(aConfiguration); + public FindBugsProcessor create(Configuration configuration) { + return new FindBugsProcessor(configuration); } } diff --git a/src/main/java/pl/touk/sputnik/processor/jshint/JsHintReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/jshint/JsHintReviewProcessorFactory.java index 395df57b..786824b1 100644 --- a/src/main/java/pl/touk/sputnik/processor/jshint/JsHintReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/jshint/JsHintReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class JsHintReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.JSHINT_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.JSHINT_ENABLED)); } @Override - public JsHintProcessor create(Configuration aConfiguration) { - return new JsHintProcessor(aConfiguration); + public JsHintProcessor create(Configuration configuration) { + return new JsHintProcessor(configuration); } } diff --git a/src/main/java/pl/touk/sputnik/processor/jslint/JsLintReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/jslint/JsLintReviewProcessorFactory.java index be0bb330..062fd7a6 100644 --- a/src/main/java/pl/touk/sputnik/processor/jslint/JsLintReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/jslint/JsLintReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class JsLintReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.JSLINT_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.JSLINT_ENABLED)); } @Override - public JsLintProcessor create(Configuration aConfiguration) { - return new JsLintProcessor(aConfiguration); + public JsLintProcessor create(Configuration configuration) { + return new JsLintProcessor(configuration); } } diff --git a/src/main/java/pl/touk/sputnik/processor/pmd/PmdReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/pmd/PmdReviewProcessorFactory.java index 315ea803..f4b7c1d3 100644 --- a/src/main/java/pl/touk/sputnik/processor/pmd/PmdReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/pmd/PmdReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class PmdReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.PMD_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.PMD_ENABLED)); } @Override - public PmdProcessor create(Configuration aConfiguration) { - return new PmdProcessor(aConfiguration); + public PmdProcessor create(Configuration configuration) { + return new PmdProcessor(configuration); } } \ No newline at end of file diff --git a/src/main/java/pl/touk/sputnik/processor/scalastyle/ScalastyleReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/scalastyle/ScalastyleReviewProcessorFactory.java index 1be331ee..785699f1 100644 --- a/src/main/java/pl/touk/sputnik/processor/scalastyle/ScalastyleReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/scalastyle/ScalastyleReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class ScalastyleReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.SCALASTYLE_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.SCALASTYLE_ENABLED)); } @Override - public ScalastyleProcessor create(Configuration aConfiguration) { - return new ScalastyleProcessor(aConfiguration); + public ScalastyleProcessor create(Configuration configuration) { + return new ScalastyleProcessor(configuration); } } diff --git a/src/main/java/pl/touk/sputnik/processor/sonar/SonarReviewProcessorFactory.java b/src/main/java/pl/touk/sputnik/processor/sonar/SonarReviewProcessorFactory.java index cdac4cbe..0c66a2a6 100644 --- a/src/main/java/pl/touk/sputnik/processor/sonar/SonarReviewProcessorFactory.java +++ b/src/main/java/pl/touk/sputnik/processor/sonar/SonarReviewProcessorFactory.java @@ -7,12 +7,12 @@ public class SonarReviewProcessorFactory implements ReviewProcessorFactory { @Override - public boolean isEnabled(Configuration aConfiguration) { - return Boolean.valueOf(aConfiguration.getProperty(GeneralOption.SONAR_ENABLED)); + public boolean isEnabled(Configuration configuration) { + return Boolean.valueOf(configuration.getProperty(GeneralOption.SONAR_ENABLED)); } @Override - public SonarProcessor create(Configuration aConfiguration) { - return new SonarProcessor(aConfiguration); + public SonarProcessor create(Configuration configuration) { + return new SonarProcessor(configuration); } }